Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the 404 page not found, when clicking on "contribution notes" in multiple README.md's translated into different languages #11487

Merged
merged 13 commits into from
Aug 30, 2024
Merged

Fixing the 404 page not found, when clicking on "contribution notes" in multiple README.md's translated into different languages #11487

merged 13 commits into from
Aug 30, 2024

Conversation

Stackoverflow-addict
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • changed the link in the german README.md to the CONTRIBUTING.md file so it links to the correct file

Before/After Screenshots/Screen Record

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Aug 30, 2024
@Stackoverflow-addict Stackoverflow-addict changed the title Fixing the 404 page not found, when clicking on "Beitragshinweise" in the german README.md Fixing the 404 page not found, when clicking on "Beitragshinweise" in the German README.md Aug 30, 2024
TobiGr
TobiGr approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@TobiGr
Copy link
Contributor

TobiGr commented Aug 30, 2024

While you are at it, could you also fix this in the other translated readmes?

@Stackoverflow-addict
Copy link
Contributor Author

While you are at it, could you also fix this in the other translated readmes?

Sure thing. Not every translation had the issue.
Now all of them should be correct.

@Stackoverflow-addict Stackoverflow-addict changed the title Fixing the 404 page not found, when clicking on "Beitragshinweise" in the German README.md Fixing the 404 page not found, when clicking on "contribution notes" in multiple README.md's translated into different languages Aug 30, 2024
TobiGr
TobiGr approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you again

@TobiGr TobiGr merged commit 035c394 into TeamNewPipe:dev Aug 30, 2024
2 checks passed
@AudricV AudricV added meta Related to the project but not strictly to code localisation / translation Everything that has to do with translations or Weblate labels Aug 30, 2024
@Stypox Stypox mentioned this pull request Nov 17, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code size/small PRs with less than 50 changed lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stackoverflow-addict @TobiGr @AudricV