Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash after adding item to a playlist caused by null thumbnail URL #11651

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

u7656655
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixed crash that can occur when adding a video with a null thumbnail URL to a playlist.
  • Crash was likely caused by incomplete API fetch due to a slow/unstable internet connection, possibly related to use of a VPN.
  • Implemented a simple not null check on the thumbnail URL before performing a comparison on this value in the code.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 27, 2024
Copy link

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TobiGr TobiGr merged commit 05a87da into TeamNewPipe:dev Oct 27, 2024
7 checks passed
@ShareASmile ShareASmile added bug Issue is related to a bug playlist Anything to do with playlists in the app labels Oct 27, 2024
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug playlist Anything to do with playlists in the app size/small PRs with less than 50 changed lines
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Crash after adding item to a playlist
3 participants