Player UI list to kotlin #11829
Open
Player UI list to kotlin #11829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And simplify the code a little
Profpatsch
force-pushed
the
PlayerUIList-to-kotlin
branch
from
9030ef5 to
2e23e77
Compare
In Kotlin, dealing with nulls works better so we don’t need optional.
Profpatsch
force-pushed
the
PlayerUIList-to-kotlin
branch
from
2e23e77 to
5b92de4
Compare
ShareASmile
added
codequality
github-actions
bot
added
size/large
Profpatsch
force-pushed
the
PlayerUIList-to-kotlin
branch
from
15d5174 to
15eca50
Compare
|
Okay I noticed a funny thing where threads would compete for modifying our UI list, so I added a Mutex around it. |
Profpatsch
force-pushed
the
PlayerUIList-to-kotlin
branch
3 times, most recently
from
e8409e1 to
2f32929
Compare
The new implementation would throw `ConcurrentModificationExceptions` when destroying the UIs. So let’s play it safe and put the list behind a mutex. Adds a helper class `GuardedByMutex` that can be wrapped around a property to force all use-sites to acquire the lock before doing anything with the data.
Profpatsch
force-pushed
the
PlayerUIList-to-kotlin
branch
from
2f32929 to
cbade0b
Compare
|
|
The code quality thingy is mostly that I marked a function as deprecated and have not yet changed all use-sites because it’s not in-scope of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small helper module
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence