Refactor EmptyStateComposable to remove modifier from EmptyStateSpec

[SttApollo]

What is it?

• Codebase improvement (dev facing), Fixes Refactor Empty State View: Followup Code Improvements #11735

Description of the changes in your PR

• Removed modifier from EmptyStateSpec to follow Compose best practices (layout should be decided by parent composable)
• Fixed EmptyStateComposable to correctly pass the modifier to the internal composable
• Updated Previews

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[SttApollo]

Hi @Stypox not sure if I need to tag anyone to review? :)

[ShareASmile]

Thank you for your contribution to NewPipe Rewrite & it is emmensly appreciated.

Regarding your query, team members are busy (mostly with their studies, exams, etc.) So it may take time.

@Isira-Seneviratne would you take a look if you have some free time!

[Stypox]

Thank you! Now the composable function follows the right standards. Sorry for taking some time to review 😬

Since now the .fillMaxWidth() calls are not in the spec anymore, but rather need to come from the outside, I think you need to update the constraint in some places (comments, related items and download fragment, see the images). After you have done so, please test all of the places that I tested in the screenshots here, to confirm everything is correctly aligned. Thanks!

You can search for random stuff on mediaccc to get 0 results, you can open this video to get 0 comments, and you can use this patch to temporarily make the related items fragment empty:

Patch

diff --git a/app/src/main/java/org/schabi/newpipe/ui/components/video/RelatedItems.kt b/app/src/main/java/org/schabi/newpipe/ui/components/video/RelatedItems.kt
index 7267c66b3..05f16d927 100644
--- a/app/src/main/java/org/schabi/newpipe/ui/components/video/RelatedItems.kt
+++ b/app/src/main/java/org/schabi/newpipe/ui/components/video/RelatedItems.kt
@@ -42,7 +42,7 @@ fun RelatedItems(info: StreamInfo) {
     }
 
     ItemList(
-        items = info.relatedItems,
+        items = listOf(), // info.relatedItems,
         mode = ItemViewMode.LIST,
         listHeader = {
             item {
@@ -72,7 +72,7 @@ fun RelatedItems(info: StreamInfo) {
                     }
                 }
             }
-            if (info.relatedItems.isEmpty()) {
+            if (info.relatedItems.isEmpty() || true) {
                 item {
                     EmptyStateComposable(EmptyStateSpec.NoVideos)
                 }
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 7c564f9e9..aa9839fe7 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -54,7 +54,7 @@ swiperefreshlayout = "1.1.0"
 # This works thanks to JitPack: https://jitpack.io/
 teamnewpipe-filepicker = "5.0.0"
 teamnewpipe-nanojson = "1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751"
-teamnewpipe-newpipe-extractor = "67f3301d9"
+teamnewpipe-newpipe-extractor = "v0.24.6"
 webkit = "1.9.0"
 work = "2.8.1"

[SttApollo]

@Stypox thank you for taking a look! I was traveling; I will address your comments this week!

[SttApollo]

@Stypox done! I tested in all the screens you shared + the patch

[Stypox]

Thanks for the effort, looks good!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Stypox]

Jfyi a build with this included will be built tonight by https://github.com/TeamNewPipe/NewPipe-refactor-nightly