PeerTube support #2201

yausername · 2019-03-09T19:39:13Z

I carefully read the contribution guidelines and agree to them.
requires Basic PeerTube support (without P2P) NewPipeExtractor#145

yausername · 2019-03-09T20:25:28Z

Here is the debug apk for testing
~~app-debug.apk.zip~~
~~app-debug.apk.zip~~
~~app-debug.apk.zip~~
~~app-debug.apk.zip~~
~~app-debug.apk.zip~~
app-debug.apk.zip

theScrabi · 2019-03-09T23:09:13Z

Nice ... although the orange is a little to bright for my taste :D.

app/src/main/java/org/schabi/newpipe/MainActivity.java

app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java

app/src/main/res/values/colors_services.xml

app/src/main/java/org/schabi/newpipe/MainActivity.java

yausername · 2019-03-10T13:41:01Z

made the suggested changes.

Booteille · 2019-04-01T14:59:46Z

What's the status on this issue?

theScrabi · 2019-04-01T20:24:43Z

Gets merged, its just middle of semester and cur. time is rare.

Booteille · 2019-04-01T22:09:56Z

Yeah, I can understand!

Thanks for took the time to answer!

Serkan-devel · 2019-06-15T15:43:04Z

Does this PR lack anything still?

TobiGr · 2019-06-15T21:00:58Z

I did not have time to review the extractor yet. The front-end implementation is good now.

TheAssassin · 2019-07-22T00:01:22Z

Contributes to TeamNewPipe/NewPipeExtractor#79.

Serkan-devel · 2019-07-23T07:53:05Z

Is it being reviewed?

theScrabi · 2019-07-23T09:25:55Z

Not yet. I may need to take a look at the backend first.

ghost · 2019-11-11T09:02:25Z

Wow, that's amazing!

Although, I found some bugs:

Share doesn't share the video's link but api's one :

Video: https://framatube.org/videos/watch/bb19bdca-4619-4e4e-84b7-c1ee409412b2
Link I got from sharing with the app: https://framatube.org/api/v1/videos/bb19bdca-4619-4e4e-84b7-c1ee409412b2
Same behaviour when you press "open in browser"

Subtitles aren't supported:

video: https://framatube.org/videos/watch/9c9de5e8-0a1e-484a-b099-e80766180a6d
on this video there are a lot of subtitles (Chinese, Dutch, English, French, German, Russian, Swedish) but no one is showed on the app:

Some characters aren't supported in comments (I found ' and ") :

In-app screenshot :
Firefox :

yausername · 2019-11-15T23:21:38Z

@ozyc I have fixed all three issues.
Please find the debug apk in the top comment.
Thanks

TobiGr · 2019-11-16T22:10:34Z

Nice. Works like a charm. We need to review the extractor PR, it has been put on hold for way to long.

yausername · 2019-12-03T01:54:31Z

the setting order and the extractor need to be updated

done

gkeegan · 2019-12-03T04:39:55Z

I think it should be kept into consideration for the future to add links to the sites in NewPipe, so that people can support them if they want. Maybe not for YouTube, but at least for PeerTube or the instances of similar services that support open source and free software.

This could be added for MediaCCC if they accept donations too.

TobiGr · 2019-12-03T13:54:49Z

I think it should be kept into consideration for the future to add links to the sites in NewPipe, so that people can support them if they want. Maybe not for YouTube, but at least for PeerTube or the instances of similar services that support open source and free software.

@gkeegan That's a good idea. Can you please open an issue for that? We should discuss where to place the donation info / buttons. There was an attempt to get some donation information of YouTube channels already.

the setting order and the extractor need to be updated

done

@yausername thanks. I'll merge this tonight.

TobiGr · 2019-12-03T21:35:37Z

I just did my final round of testing. Everything works fine :)
There is only one child in the rooms which makes trouble all the time: KitKat... There is a ssl exception with https://framatube.org. However, other peertube instances work fine.

DefaultKioskFragment@9d4f3918: onError() called with: exception = [javax.net.ssl.SSLHandshakeException: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0xb9534dc0: Failure in SSL library, usually a protocol error
    error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version (external/openssl/ssl/s23_clnt.c:741 0x8d95e990:0x00000000)]

#2792 might solve this issue. For this reason, I'd like to proceed and merge this?
@Stypox @yausername @theScrabi @gkeegan Do you consider this as blocking? (this problem has existed before and made media.ccc unusable for KitKat users, see #2777)

gkeegan · 2019-12-03T23:42:15Z

I don't think it should be blocked from merge if there is a possible fix on the way. So long as a release doesn't happen before 2792 is merged (or issue is fixed by other methods), everything should be fine.

I think that discussion may need to happen in the future about what to do with KitKat as it seems problematic.

Stypox · 2019-12-04T06:35:47Z

On Android 7.1 it currently works only for some instances (e.g. https://diode.zone works while https://framatube.org gives "Network Error")

Stypox · 2019-12-04T06:38:46Z

And if I try to remove and re-insert Framatube it tells me "failed to validate instance"

(Also, the first letter of the error should probably be uppercase)

yausername · 2019-12-04T23:32:06Z

And if I try to remove and re-insert Framatube it tells me "failed to validate instance"

@Stypox Does it happen every time? I tried on a 7.1.1 emulator and not able to reproduce.

(Also, the first letter of the error should probably be uppercase)

fixed

TobiGr · 2019-12-06T23:32:50Z

On Android 7.1 it currently works only for some instances (e.g. https://diode.zone works while https://framatube.org gives "Network Error")

@Stypox Can you please verify that this is also the ssl certificate problem? In this case, I'd like to merge.

Stypox · 2019-12-09T21:00:58Z

@yausername correct the first lowercase letter also for other strings you added

Stypox · 2019-12-09T21:04:45Z

@TobiGr @yausername the issue is caused by a failed handshake, so this can be merged.

javax.net.ssl.SSLProtocolException: SSL handshake terminated: ssl=0x7dd8c31180: Failure in SSL library, usually a protocol error
error:10000410:SSL routines:OPENSSL_internal:SSLV3_ALERT_HANDSHAKE_FAILURE (external/boringssl/src/ssl/s3_pkt.c:610 0x7dd8cfdd40:0x00000001)
error:1000009a:SSL routines:OPENSSL_internal:HANDSHAKE_FAILURE_ON_CLIENT_HELLO (external/boringssl/src/ssl/s3_clnt.c:764 0x7dead5cf76:0x00000000)

yausername · 2019-12-10T07:29:02Z

@yausername correct the first lowercase letter also for other strings you added

done

Outdated review

B0pol · 2019-12-10T19:41:02Z

Wow, finally merged, huge thanks to you !!!
by the way, I found there was a bounty for PeerTube : TeamNewPipe/NewPipeExtractor#79
Did you know ? I hope it's still available and you'll win it 🥇

app/src/main/res/values/strings.xml

theScrabi · 2020-01-07T16:36:30Z

I was asked for paying out the bounty for this support:
TeamNewPipe/NewPipeExtractor#79
I don't have access to the money but Felix who wants to pay it out asked me to whom to pay it.

yausername · 2020-01-07T20:01:49Z

@theScrabi
Thanks for offering but I did it just for the fun. I don't want to take money for it. Besides the P2P part is not even implemented.

theScrabi · 2020-01-08T09:36:21Z

I know and understand that :) You may have to deal that out with Felix then.

theScrabi · 2020-01-08T09:37:38Z

If we finally had our foundation we could take the money and organize some events or merch with that.

yausername added 7 commits October 12, 2018 02:34

added peertube

fc31458

updated extractor

cc6989b

merged dev

d61797f

Merge branch 'dev' into peertube

c1efa78

Merge branch 'dev' into peertube

9530af9

added themeing for peertube, change peertube instance

845663f

merged upstream/dev, changes for peertube support

d90b1ca

theScrabi previously requested changes Mar 9, 2019

View reviewed changes

yausername added 2 commits March 10, 2019 17:30

init services in app onCreate

2581fa4

darker color for peertube

a8b5534

reordered services

039a8e0

theScrabi added feature request Issue is related to a feature in the app deep review required Maintainer must double check/test/review this due to changes in API or architecture labels Jul 21, 2019

merged upstream/dev

b6be586

yausername added 2 commits November 20, 2019 03:48

merged upstream/dev

596005c

updated extractor

ceabfd1

gkeegan mentioned this pull request Dec 3, 2019

Add donation info/links to pages to services NewPipe uses #2839

Open

grammar fix

d2a59ec

merged upstream/dev

fd5f4d9

more grammar fix

a0151f2

TobiGr approved these changes Dec 10, 2019

View reviewed changes

TobiGr merged commit b2bbdc6 into TeamNewPipe:dev Dec 10, 2019

This was referenced Dec 12, 2019

Release 0.18.0 #2861

Closed

Release 0.18.0 #2862

Merged

TobiGr reviewed Dec 30, 2019

View reviewed changes

app/src/main/res/values/strings.xml Show resolved Hide resolved

theScrabi mentioned this pull request Jan 7, 2020

Add PeerTube service to NewPipe TeamNewPipe/NewPipeExtractor#79

Closed

B0pol mentioned this pull request Jan 20, 2020

[PeerTube] added metadata, fix descriptions, fix thumbnail, fix upload date, fix age limit, update tests. TeamNewPipe/NewPipeExtractor#239

Merged

3 tasks

sadr0b0t mentioned this pull request Jan 27, 2020

Добавить поддержку PeerTube sadr0b0t/yashlang#6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PeerTube support #2201

PeerTube support #2201

yausername commented Mar 9, 2019

yausername commented Mar 9, 2019 •

edited

Loading

theScrabi commented Mar 9, 2019

yausername commented Mar 10, 2019

Booteille commented Apr 1, 2019

theScrabi commented Apr 1, 2019

Booteille commented Apr 1, 2019

Serkan-devel commented Jun 15, 2019

TobiGr commented Jun 15, 2019

TheAssassin commented Jul 22, 2019

Serkan-devel commented Jul 23, 2019

theScrabi commented Jul 23, 2019

ghost commented Nov 11, 2019 •

edited by ghost

Loading

yausername commented Nov 15, 2019 •

edited

Loading

TobiGr commented Nov 16, 2019

yausername commented Dec 3, 2019

gkeegan commented Dec 3, 2019 •

edited

Loading

TobiGr commented Dec 3, 2019

TobiGr commented Dec 3, 2019 •

edited

Loading

gkeegan commented Dec 3, 2019

Stypox commented Dec 4, 2019

Stypox commented Dec 4, 2019

yausername commented Dec 4, 2019 •

edited

Loading

TobiGr commented Dec 6, 2019

Stypox commented Dec 9, 2019

Stypox commented Dec 9, 2019 •

edited

Loading

yausername commented Dec 10, 2019

B0pol commented Dec 10, 2019

theScrabi commented Jan 7, 2020

yausername commented Jan 7, 2020

theScrabi commented Jan 8, 2020

theScrabi commented Jan 8, 2020

PeerTube support #2201

PeerTube support #2201

Conversation

yausername commented Mar 9, 2019

yausername commented Mar 9, 2019 • edited Loading

theScrabi commented Mar 9, 2019

yausername commented Mar 10, 2019

Booteille commented Apr 1, 2019

theScrabi commented Apr 1, 2019

Booteille commented Apr 1, 2019

Serkan-devel commented Jun 15, 2019

TobiGr commented Jun 15, 2019

TheAssassin commented Jul 22, 2019

Serkan-devel commented Jul 23, 2019

theScrabi commented Jul 23, 2019

ghost commented Nov 11, 2019 • edited by ghost Loading

yausername commented Nov 15, 2019 • edited Loading

TobiGr commented Nov 16, 2019

yausername commented Dec 3, 2019

gkeegan commented Dec 3, 2019 • edited Loading

TobiGr commented Dec 3, 2019

TobiGr commented Dec 3, 2019 • edited Loading

gkeegan commented Dec 3, 2019

Stypox commented Dec 4, 2019

Stypox commented Dec 4, 2019

yausername commented Dec 4, 2019 • edited Loading

TobiGr commented Dec 6, 2019

Stypox commented Dec 9, 2019

Stypox commented Dec 9, 2019 • edited Loading

yausername commented Dec 10, 2019

B0pol commented Dec 10, 2019

theScrabi commented Jan 7, 2020

yausername commented Jan 7, 2020

theScrabi commented Jan 8, 2020

theScrabi commented Jan 8, 2020

yausername commented Mar 9, 2019 •

edited

Loading

ghost commented Nov 11, 2019 •

edited by ghost

Loading

yausername commented Nov 15, 2019 •

edited

Loading

gkeegan commented Dec 3, 2019 •

edited

Loading

TobiGr commented Dec 3, 2019 •

edited

Loading

yausername commented Dec 4, 2019 •

edited

Loading

Stypox commented Dec 9, 2019 •

edited

Loading