fixup for #2149 (missing buttons) #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
reviewed
Aug 2, 2019
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
|
Can confirm. @theScrabi we might want to add this to 0.17.0, too. |
|
So either @kapodamy you re create this pr but trying to merge into release_0.17.0, or we merge now and rebase into release_0.17.0 |
|
I wanted to rebase the release branch onto dev, but forgot it. Will do it |
* fix start/pause buttons disappear, issued by RecyclerView re-draw * show start/pause buttons in pair to avoid confusions
TobiGr
reviewed
Aug 5, 2019
@TobiGr |
|
@kapodamy I also can not reproduce it. I have no idea what caused this strange behavior yesterday. |
Ah una pregunta español pero con palabras de ingles. 😀 |
use "ifRoom" and "always" in cases where is possible
This was referenced Aug 13, 2019
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some buttons on the download page dissapears when the screen goes off or the app is switched