-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move player controls up on Android 10 #3003
Conversation
Why not to switch to API 29 then? And could you please give a link to that special API? I'll need it in my app soon Also the class you edited is no longer needed, see #2907 |
also, yeah i think the compileSdk should be moved to 29 @TobiGr |
This fix don't work on my test build. There is any type of changes that I should apply to project to make ot working? |
#3337 addressed the same problem, but found a different solution. Can you please tell us if the problem is solved in this APK? |
There is a solution also for background player? |
@Oizaro no. |
If I'm not wrong this PR of harshlele should fix the wrong behaviour of background player: But not work. |
Galaxy's One UI 2.0 and some custom ROMs implement a true full-screen gesture by setting the height of the navigation bar to zero. My PR also uses the height of the navigation bar, which causes problems on certain devices. |
679bc75
to
2aeccc0
Compare
No progress since a year, no GitHub actions build and merge conflicts. Closing this for now. Feel free to reopen it when there is progress again. |
No need to reopen. Superseded by #6824. |
Temporary fix for #2931. It moves the player controls up on Android 10 so it doesn't conflict with the gesture navigation on Android 10.
The SDK version 29 has a special API for moving UI elements away from the navigation area, but the build/compileSdk is 28, so I couldn't use that.