Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move player controls up on Android 10 #3003

Closed
wants to merge 1 commit into from

Conversation

harshlele
Copy link
Contributor

Temporary fix for #2931. It moves the player controls up on Android 10 so it doesn't conflict with the gesture navigation on Android 10.

The SDK version 29 has a special API for moving UI elements away from the navigation area, but the build/compileSdk is 28, so I couldn't use that.

@TobiGr TobiGr added bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software labels Jan 25, 2020
@avently
Copy link
Contributor

avently commented Feb 29, 2020

The SDK version 29 has a special API for moving UI elements away from the navigation area

Why not to switch to API 29 then?

And could you please give a link to that special API? I'll need it in my app soon

Also the class you edited is no longer needed, see #2907

@harshlele
Copy link
Contributor Author

@harshlele
Copy link
Contributor Author

also, yeah i think the compileSdk should be moved to 29 @TobiGr

@ghost
Copy link

ghost commented May 13, 2020

@harshlele

This fix don't work on my test build. There is any type of changes that I should apply to project to make ot working?

@TobiGr
Copy link
Contributor

TobiGr commented May 13, 2020

#3337 addressed the same problem, but found a different solution. Can you please tell us if the problem is solved in this APK?
app-debug.apk.zip

@ghost
Copy link

ghost commented May 13, 2020

@TobiGr

There is a solution also for background player?

@TobiGr
Copy link
Contributor

TobiGr commented May 13, 2020

@Oizaro no.

@ghost
Copy link

ghost commented May 13, 2020

@TobiGr

If I'm not wrong this PR of harshlele should fix the wrong behaviour of background player:

But not work.

@AioiLight
Copy link
Contributor

Galaxy's One UI 2.0 and some custom ROMs implement a true full-screen gesture by setting the height of the navigation bar to zero.
Therefore, even if you calculate from the height of the navigation bar, the gesture cannot be performed correctly on some devices.
The solution is either to move the background player controls up a bit, or to some extent, even on a device with a zero height navigation bar.

My PR also uses the height of the navigation bar, which causes problems on certain devices.

@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@litetex litetex marked this pull request as draft October 1, 2021 17:06
@litetex
Copy link
Member

litetex commented Oct 1, 2021

No progress since a year, no GitHub actions build and merge conflicts.

Closing this for now. Feel free to reopen it when there is progress again.

@litetex litetex closed this Oct 1, 2021
@opusforlife2
Copy link
Collaborator

No need to reopen. Superseded by #6824.

@litetex litetex mentioned this pull request Oct 10, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants