Add possibility to open PeerTube links in NP for some instances (without needing to share to NP) #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wb9688
requested changes
Apr 9, 2020
There was a problem hiding this comment.
Please add all instances from https://instances.joinpeertube.org/instances. It would also be nice if we could add a test that checks whether we have all instances (in case the list changes). Also add support for the channels.
|
@wb9688 That are 449 instances. I am not sure if we should add them all. |
|
@TobiGr: It's "only" 449 instances. Why should we not add them to the manifest? |
B0pol
changed the title
TobiGr
reviewed
Apr 9, 2020
B0pol
force-pushed
the
playlist_peertube
branch
3 times, most recently
from
73a5013 to
9212c28
Compare
|
@B0pol added some instances now. Please suggest more instances if you are missing one. |
B0pol
changed the title
|
Can you add this PR to 0.19.3 milestone? |
B0pol
changed the title
B0pol
changed the title
The one used for tests, popular instances and user wanted (e.g. la quadrature du net, video.lqdn.fr, or @TheAssassin instance, media-assassinate-you.net)
TobiGr
previously approved these changes
May 16, 2020
TobiGr
approved these changes
Jun 26, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Add support for opening PeerTube links in NewPipe without needing to share it to newpipe (see in manifest for the instances choosen).
Fixes the following issue(s)
No issue fixed, we discussed previously that the default instance should be added, I also added instances we are using for tests in extractor, and media assassinate you which is the instance where some NewPipe videos are hosted (cf this video), and some other popular peertube instances.
Relies on the following changes
TeamNewPipe/NewPipeExtractor#307 : for playlist part. It's really needed because otherwise it will cause lots of crashes "could not get name" as playlist follow this pattern : videos/watch/playlist, then current extractor think it's a video and not playlist
Testing apk
peertube_playlists.zip
Agreement