Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply extractor changes: Add Page class and remove getNextPageUrl() #3441

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Apply extractor changes: Add Page class and remove getNextPageUrl() #3441

merged 2 commits into from
Jul 7, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Apr 15, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Relies on the following changes

TeamNewPipe/NewPipeExtractor#314

Agreement

@wb9688 wb9688 marked this pull request as ready for review April 15, 2020 14:24
@wb9688 wb9688 modified the milestones: 0.20.0, 0.19.4 Apr 15, 2020
@B0pol B0pol added the feature request Issue is related to a feature in the app label May 17, 2020
@Stypox Stypox modified the milestones: 0.19.4, 0.19.5 May 28, 2020
TobiGr
TobiGr previously approved these changes Jun 23, 2020
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to change the extractor version before merging

@TobiGr TobiGr merged commit e12e6dd into TeamNewPipe:dev Jul 7, 2020
@TobiGr TobiGr changed the title Next page stuff Apply changes: Add Page class and remove getNextPageUrl() Jul 7, 2020
@TobiGr TobiGr changed the title Apply changes: Add Page class and remove getNextPageUrl() Apply extractor changes: Add Page class and remove getNextPageUrl() Jul 7, 2020
This was referenced Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants