Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy video title #3772

Merged
merged 6 commits into from
Jun 13, 2020
Merged

Copy video title #3772

merged 6 commits into from
Jun 13, 2020

Conversation

adinilfeld
Copy link
Contributor

@adinilfeld adinilfeld commented Jun 10, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Allows user to long-press on the video title in the detail screen to copy it to the clipboard
  • Brief "Copied to clipboard" toast appears

Fixes the following issue(s)

closes #3768

Testing apk

app-debug.apk.zip

Agreement

@adinilfeld
added a copyToClipboard method to ShareUtils, and modified CommentsMi…
267e114 
…niInfoItemHolder and VideoDetailFragment to use the new method.
@adinilfeld adinilfeld requested a review from wb9688 June 10, 2020 22:23
Stypox
Stypox requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I just pointed out two small things ;-)

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java Outdated Show resolved Hide resolved
@adinilfeld adinilfeld requested review from wb9688 and Stypox June 11, 2020 16:40
wb9688
wb9688 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@wb9688 wb9688 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good now. Next time please mark conversations on GitHub as resolved when you've fixed them.

@TobiGr TobiGr added this to the 0.19.6 milestone Jun 13, 2020
@TobiGr TobiGr merged commit 9ef7688 into TeamNewPipe:dev Jun 13, 2020
This was referenced Jul 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B0pol B0pol B0pol approved these changes

@wb9688 wb9688 wb9688 approved these changes

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Awaiting requested review from Stypox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.6
Development

Successfully merging this pull request may close these issues.

Copy the media title
5 participants
@adinilfeld @TobiGr @Stypox @wb9688 @B0pol