Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Stored(File|Directory)Helper into NewPipe #3781

Closed
wants to merge 2 commits into from
Closed

Move Stored(File|Directory)Helper into NewPipe #3781

wants to merge 2 commits into from

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Jun 14, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This moves StoredFileHelper and StoredDirectoryHelper into NewPipe, while fixing a lot of code style issues.

Relies on the following changes

#3777

Agreement

@wb9688 wb9688 mentioned this pull request Jun 14, 2020
Closed
5 tasks
@wb9688 wb9688 modified the milestones: 0.19.6, 0.20.0 Jun 28, 2020
@wb9688 wb9688 requested a review from Stypox July 29, 2020 14:01
Stypox
Stypox approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go imo

@wb9688 wb9688 closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wb9688 @Stypox