Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file picker for export DB #3785

Closed
wants to merge 2 commits into from
Closed

Use file picker for export DB #3785

wants to merge 2 commits into from

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Jun 15, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Use file picker with pre-filled file name for exporting database instead of using a directory picker.

@opusforlife2: Could you test this as well (just export/import DB with both SAF/NNFP)?

Relies on the following changes

#3777

Testing apk

app-debug.apk.zip

Agreement

@wb9688 wb9688 mentioned this pull request Jun 15, 2020
5 tasks
@opusforlife2
Copy link
Collaborator

Everything works correctly.

@wb9688 wb9688 modified the milestones: 0.19.6, 0.20.0 Jun 28, 2020
Stypox
Stypox previously approved these changes Jul 29, 2020
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly on my 7.0 phone. I firstly opened the app with SAF enabled, then imported a database with SAF disabled using SAF and everything worked smoothly. Thank you :-D
The only issue I could find is that Huawei's file picker opens ZIP files, so it can be difficult to import a ZIP file using it (I had to manually select the file via the three-dot menu). Is there an option to provide to SAF specifying not to open archives (I guess not, unfortunately)?

@wb9688 wb9688 closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants