Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings switches are not red anymore #5899

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Mar 24, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Reverts part of 731c65c, while rebasing I didn't notice that different themes were being used for settings.

Fixes the following issue(s)

Fixes color switches in settings being white instead of red.

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Stypox Stypox mentioned this pull request Mar 24, 2021
7 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Mar 24, 2021
@TobiGr TobiGr merged commit 67afd05 into TeamNewPipe:dev Mar 24, 2021
@Stypox Stypox deleted the fix-settings-theme branch March 24, 2021 10:31
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 22, 2021
…theme

Fix settings switches are not red anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants