Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoLoginRequired in Readme file #5994

Merged
merged 1 commit into from
May 4, 2021

Conversation

sauravrao637
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

  • Need to make appropriate changes in other translations of README

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Stypox
Copy link
Member

Stypox commented Apr 3, 2021

This should be added to all readmes

@sauravrao637
Copy link
Contributor Author

@Stypox let's add in one and then can open an issue for adding translations in other

@AudricV AudricV added the meta Related to the project but not strictly to code label Apr 3, 2021
@AudricV AudricV changed the title added NoLoginRequired in readme file Add NoLoginRequired in Readme file Apr 3, 2021
@Stypox
Copy link
Member

Stypox commented Apr 4, 2021

I think this can be translated with an online translator and updated in all readmes, then if a traslator thinks he has a better translation he can always change it. Otherwise it would be difficult to gather all translators

@sauravrao637
Copy link
Contributor Author

@Stypox done :)

@sauravrao637 sauravrao637 changed the title Add NoLoginRequired in Readme file Add NoLoginRequired in Readme files Apr 5, 2021
triallax
triallax previously approved these changes Apr 8, 2021
@nadiration
Copy link
Contributor

@sauravrao637 This translation [Somali] is wrong. You should never use Google translate. If you don't know a language leave it be.

@nadiration
Copy link
Contributor

nadiration commented Apr 10, 2021

@Stypox That's is not a good idea. Online translations (Google Translate etc) are not 'acurate', they are out of context and confusing plus it's not the same with all languages. Some languages are a mess.

I think this can be translated with an online translator and updated in all readmes, then if a traslator thinks he has a better translation he can always change it. Otherwise it would be difficult to gather all translators

@triallax
Copy link
Contributor

I agree with @nadiration. I think it would be best in general to just edit the languages that one knows in a PR and leave the rest for other PRs by people who actually know the languages.

@sauravrao637
Copy link
Contributor Author

I agree with @Stypox as if some translation is wrong one would notice and change but if it's not there it might not get there ever.

@triallax
Copy link
Contributor

@sauravrao637 Google Translate and friends can create confusing translations, which in my book are worse than no translation at all.

@sauravrao637
Copy link
Contributor Author

sauravrao637 commented Apr 20, 2021

@sauravrao637 Google Translate and friends can create confusing translations, which in my book are worse than no translation at all.

okay I'll revert the last commit :)
and open an issue to add translations in other languages after this is merged).

@sauravrao637 sauravrao637 changed the title Add NoLoginRequired in Readme files Add NoLoginRequired in Readme file Apr 21, 2021
@triallax triallax merged commit f80b1fb into TeamNewPipe:dev May 4, 2021
@triallax
Copy link
Contributor

triallax commented May 4, 2021

Thanks!

@opusforlife2
Copy link
Collaborator

@mhmdanas Question. There are 6 CI tests for this PR. Do all of them produce their own artifact APKs? Or is there a single artifact produced for the entire PR at its latest commit?

@sauravrao637
Copy link
Contributor Author

@opusforlife2 this is meta improvement and doesn't affect the apk produced so all artifacts are useless with this PR

@triallax
Copy link
Contributor

triallax commented May 7, 2021

@sauravrao637 @opusforlife2's question was probably not specific to this PR.

@opusforlife2 only build-and-test-jvm uploads an APK. All the checks curiously seem to have been run twice for this PR for whatever reason, so there are two artifacts, one for each build-and-test-jvm run, but usually it would be only one. Also, the checks are run whenever something is pushed, so there isn't necessarily one artifact for each PR, but one for each CI run.

If anything is unclear feel free to ask me, but not here since it would be off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants