Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show 'download has started' toast when download is started #6139

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Only show 'download has started' toast when download is started #6139

merged 1 commit into from
Apr 22, 2021

Conversation

subraizada3
Copy link
Contributor

@subraizada3 subraizada3 commented Apr 22, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Only show the 'download has started' toast when a download has started. Note, I haven't compiled and tested this.

Fixes the following issue(s)

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/2554180297/artifacts/55556817

Due diligence

@subraizada3
Copy link
Contributor Author

This CI/CD setup is pretty neat! The APK works properly for me.

@Redirion
Copy link
Member

looks good, but can you change the PR name to a more meaningful name please?

@subraizada3 subraizada3 changed the title Fix issue #6138? Only show 'download' has started toast when a download has actually started Apr 22, 2021
@subraizada3 subraizada3 changed the title Only show 'download' has started toast when a download has actually started Only show 'download has started' toast when download is started Apr 22, 2021
@subraizada3
Copy link
Contributor Author

Done.

Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Redirion Redirion merged commit ceb930a into TeamNewPipe:dev Apr 22, 2021
@AudricV AudricV added bug Issue is related to a bug downloader Issue is related to the downloader labels Apr 23, 2021
This was referenced May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Download has started' toast notification sometimes appears when it shouldn't
3 participants