Save backup import/export location for future import/exports #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATofighi
changed the title
5 tasks
XiangRongLin
requested changes
May 20, 2021
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Outdated
Show resolved
Hide resolved
Yes, I have tried to cover it in |
XiangRongLin
requested changes
May 21, 2021
app/src/test/java/org/schabi/newpipe/util/FilePathHelperTest.java
Outdated
Show resolved
Hide resolved
Not that i can think of |
|
Can you also remove the conversions between file and path in your tests. Like this XiangRongLin@376e5c1 |
Yes, I merge your branch with mine. |
XiangRongLin
approved these changes
May 21, 2021
Closed
2 tasks
|
I don't know how to rebase #5415 on top of this... I think that storing the last used path would require some more work in |
Stypox
added a commit
to Stypox/NewPipe
that referenced
this pull request
Jun 6, 2021
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
Stypox
added a commit
to Stypox/NewPipe
that referenced
this pull request
Jun 6, 2021
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
Stypox
added a commit
to Stypox/NewPipe
that referenced
this pull request
Jun 8, 2021
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
To save location of import/export, I add a new preference key for
import_export_pathand save this preference on result of file chooser activity and send it on intent of file chooser on later tries.So as a user, If a export data on folder
foo, when I want to import this data, file chooser showfooas start path.Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence