Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search not accepting key input after closing player overlay #7592

Closed
wants to merge 1 commit into from

Conversation

dkramer95
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixes issue where Keyboard input was not reflecting in Search bar after closing Player overlay.
    • Changed moveFocusToMainFragment to false when the bottom sheet is STATE_HIDDEN. This should prevent focus loss for toolbar_search_edit_text view.

Before/After Screenshots/Screen Record

  • Before:
search-focus-before.mp4
  • After:
search-focus-after.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@litetex litetex added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Dec 29, 2021
@litetex
Copy link
Member

litetex commented Jan 1, 2022

Thank you for the PR.
However this does not fix the problem completely and even causes more problems.
E.g. you are unable to use the app/search something once you close the mini-player (because the focus is on the closed player):

NPDemoSearchFixBreaksApp.gif.mp4

I will provide a better fix with #7607

@litetex
Copy link
Member

litetex commented Jan 1, 2022

Superseded by #7607

Anyway thank you for the PR and the work! 😄

@litetex litetex closed this Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard doesn't appear on search sometimes
2 participants