Add long press action on hashtags and web links in descriptions #7725

AudricV · 2022-01-30T17:10:50Z

What is it?

Feature (user facing)

Description of the changes in your PR

This PR adds a long press action on web links and hashtags which copy them to clipboard.

To do so:

Some changes in our TextView class have been required and metadata items are now using a NewPipeTextView instead of a standard TextView.
Three new classes have been added: a custom LinkMovementMethod class (adapted from a StackOverflow answer), a custom ClickableSpan class have been added in order to set a long press event and a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils.

Before/After Screenshots/Screen Record

Before:

Long.press.links.and.hashtags.before.mp4

After:

Long.press.links.and.hashtags.after.mp4

Fixes the following issue(s)

Fixes Links in description can't be copied #3253

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

litetex

Note:

The videos are unplayable (can't view them in Firefox or Chromium-based browsers)
There are some Sonar warnings

AudricV · 2022-01-30T17:33:37Z

The videos are unplayable (can't view them in Firefox or Chromium-based browsers)

I had to compress them, unfortunately, but it seems Video Transcoder converted them in an unplayable format for browsers (you can play them in VLC I think)

SameenAhnaf · 2022-01-30T17:46:12Z

@litetex You may download the video with Video Download Helper. I eventually had to download, the video is still loading on my browser.

@TiA4f8R I included some suggestions in #7097. I think, it'll be more suitable for copying links.

AudricV · 2022-01-30T18:17:10Z

So what's the best way to proceed when long pressing links and hashtags?

copy them directly to clipboard
show an alert dialog to allow opening/searching them and copying them to clipboard

I am not all a UX designer so feedback is appreciated.

opusforlife2 · 2022-01-30T18:19:36Z

@TiA4f8R The usual behaviour for Android apps is to take the specific action when directly tapping, and to copy to clipboard (or something else) when long-pressing.

AudricV · 2022-01-30T18:23:51Z

Ok, I will do this.

Edit: done

sonarqubecloud · 2022-01-30T19:41:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

ktprograms · 2022-01-31T12:48:14Z

@TiA4f8R Can you please add this functionality to timestamps in the description? (Example video with timestamps: https://www.youtube.com/watch?v=mOSirVeP5lo)

Thanks!

Stypox

Looks almost good to me ;-)

app/src/main/java/org/schabi/newpipe/util/external_communication/TextLinkifier.java

AudricV · 2022-07-19T20:11:11Z

Note: even if it seems I forgot this pull request, I didn't forget it and I will continue to work on this, maybe once my work is done on other features/bug fixes I have on NewPipe projects.

AudricV · 2022-09-07T20:53:20Z

@TiA4f8R Can you please add this functionality to timestamps in the description? (Example video with timestamps: https://www.youtube.com/watch?v=mOSirVeP5lo)

Thanks!

@ktprograms Done (in the app side) on services on which timestamps supported (otherwise, a fallback to copy timestamp raw text is made).

AudricV · 2022-09-07T20:54:06Z

Note that the Sonar bug is a false positive, as nullity is checked by Utils.isBlank method of the extractor as the first instruction of the method and that the TODO that I added, is of course, not feasible in this PR.

sonarqubecloud · 2022-11-29T11:27:07Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

Stypox

At this point you should probably create a library for clipboard & sharing handling 😂

I tested on API 33 emulated, API 22 emulated and my API 29 phone and everything works well. Comments with links now behave correctly :-D

The few comments I left are really small things: once you solve them, you can merge this PR yourself. Code looks good. I rebased and solved conflicts, otherwise it wouldn't build, because of the missing extractor commit build on Jitpack.

app/src/main/java/org/schabi/newpipe/util/external_communication/TextLinkifier.java

app/src/main/java/org/schabi/newpipe/util/CommentTextOnTouchListener.java

app/src/main/java/org/schabi/newpipe/util/TouchUtils.java

app/src/main/java/org/schabi/newpipe/views/LongPressLinkMovementMethod.java

…long-press This commit adds the ability to copy to clipboard hashtags, URLs and timestamps when long-pressing them. Some changes in our TextView class related to text setting have been required and metadata items are now using a NewPipeTextView instead of a standard TextView. Six new classes have been added: - a custom LinkMovementMethod class; - a custom ClickableSpan class, LongPressClickableSpan, in order to set a long press event; - a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils; - three implementations of LongPressClickableSpan used when linkifying text: - HashtagLongPressClickableSpan for hashtags; - TimestampLongPressClickableSpan for timestamps; - UrlLongPressClickableSpan for URLs.

sonarqubecloud · 2023-01-15T11:01:11Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

0.0% Coverage
0.0% Duplication

Stypox

LGTM, thanks! The bug reported by Sonar is wrong: it says content might be null but actually we check for isBlankness above.

goyalyashpal · 2023-01-22T21:11:48Z

The videos are unplayable (can't view them in Firefox or Chromium-based browsers)
- @ litetex at Add long press action on hashtags and web links in descriptions #7725 (review)

kinda strange that yeah, it doesn't play on desktop browser ( Vivaldi | 5.5.2805.48 (Stable channel) (64-bit) ; Chrome/106.0.0.0), but is working fine on android browser (Vivaldi 5.6.2868.29)

goyalyashpal · 2023-01-22T21:47:58Z

but i still don't understand the premise of this PR.

like, selecting tags and links was available before this pr as well:

"Enable selecting text in description"
press and hold on links to select and copy them
the only problem was that clicking them caused them to open

This pr shows that press and holding them automatically copies them - one tap saved.

But what happens in this pr when u single tap on links/tags? Did this problem was an effort to solve this single tap problem?

Following is a screenrecord from Newpipe v0.23.3 i.e. back from 2022.08'

v0.23.3-newpipe.mp4

Stypox · 2023-01-23T09:13:55Z

The videos are unplayable

I don't understand what you are referring to.

Did this problem was an effort to solve this single tap problem?

What do you mean by "single tap problem"? For me single taps work normally. Also, this PR was also needed because soon we will have comments with copiable links and hashtags.

goyalyashpal · 2023-01-24T12:56:14Z

I don't understand what you are referring to.

sorry, have updated with link. : #7725 (review)

single tap problem"? For me single taps work normall

this is shown in the screen recording - i meant that on single tapping, the links were opening. i was asking that was that considered the problem?

Also, this PR was also needed because soon we will have comments with copiable links and hashtags.

yeah, that is understandable. the thing that confused me was the following quoted part: "reopening as we are not able to copy full links" which we definitely were.

Reopening as we are not able to copy full links on YouTube. I will open a PR which will add this ability soon.
- @ AudricV at #3253 (comment)

Stypox · 2023-01-28T20:50:10Z

which we definitely were

Oh ok, I see what you meant. Yeah, in the description you were already able to copy YouTube links, since those are always shown in full. I am not sure about Peertube though, where Markdown is employed, and [link](https://example.org) gets transformed into the literal "link". Unless Android is able to copy rich text, I doubt you would be able to copy links from there. So the YouTube description was just a special case among other services' descriptions and also comments.

goyalyashpal · 2023-01-29T04:54:20Z

about Peertube though, where Markdown is employed,
Unless Android is able to copy rich text,

ohw ohkayh, yeah, makes sense then 👍

AudricV added the feature request Issue is related to a feature in the app label Jan 30, 2022

triallax added the GUI Issue is related to the graphical user interface label Jan 30, 2022

triallax self-requested a review January 30, 2022 17:15

litetex reviewed Jan 30, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

AudricV force-pushed the add-long-press-actions-on-hashtags-and-links-in-descriptions branch from 0c16ea7 to 770d9c8 Compare January 30, 2022 19:32

AudricV changed the title ~~Add long press actions on hashtags and web links in descriptions~~ Add long press action on hashtags and web links in descriptions Jan 30, 2022

Stypox requested changes Feb 16, 2022

View reviewed changes

app/src/main/java/org/schabi/newpipe/util/external_communication/TextLinkifier.java Outdated Show resolved Hide resolved

AudricV marked this pull request as draft February 16, 2022 13:38

Stypox force-pushed the dev branch from a81dbe2 to dc7fce8 Compare June 24, 2022 16:53

triallax removed their request for review August 21, 2022 21:36

AudricV force-pushed the add-long-press-actions-on-hashtags-and-links-in-descriptions branch from 770d9c8 to cb703bd Compare September 7, 2022 20:33

AudricV marked this pull request as ready for review September 7, 2022 20:34

AudricV requested a review from Stypox September 28, 2022 15:38

Stypox force-pushed the add-long-press-actions-on-hashtags-and-links-in-descriptions branch from cb703bd to aaae49a Compare November 29, 2022 11:19

Stypox approved these changes Nov 29, 2022

View reviewed changes

AudricV and others added 2 commits January 15, 2023 11:40

Create text subpackage in util

22c201b

Stypox force-pushed the add-long-press-actions-on-hashtags-and-links-in-descriptions branch from aaae49a to 22c201b Compare January 15, 2023 10:51

TeamNewPipe deleted a comment from sonarqubecloud bot Jan 15, 2023

Stypox approved these changes Jan 15, 2023

View reviewed changes

Stypox merged commit 2db2918 into TeamNewPipe:dev Jan 15, 2023

Stypox mentioned this pull request Jan 22, 2023

Release v0.25.0 (please TEST!) #9712

Closed

3 tasks

goyalyashpal mentioned this pull request Jan 22, 2023

Links in description can't be copied #3253

Closed

AudricV deleted the add-long-press-actions-on-hashtags-and-links-in-descriptions branch January 22, 2023 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add long press action on hashtags and web links in descriptions #7725

Add long press action on hashtags and web links in descriptions #7725

AudricV commented Jan 30, 2022 •

edited

Loading

litetex left a comment •

edited

Loading

AudricV commented Jan 30, 2022

SameenAhnaf commented Jan 30, 2022 •

edited by AudricV

Loading

This comment has been minimized.

AudricV commented Jan 30, 2022

opusforlife2 commented Jan 30, 2022

AudricV commented Jan 30, 2022 •

edited

Loading

sonarqubecloud bot commented Jan 30, 2022

ktprograms commented Jan 31, 2022

Stypox left a comment

AudricV commented Jul 19, 2022

AudricV commented Sep 7, 2022

AudricV commented Sep 7, 2022 •

edited by opusforlife2

Loading

sonarqubecloud bot commented Nov 29, 2022

Stypox left a comment •

edited

Loading

sonarqubecloud bot commented Jan 15, 2023

Stypox left a comment

goyalyashpal commented Jan 22, 2023 •

edited

Loading

goyalyashpal commented Jan 22, 2023

Stypox commented Jan 23, 2023

goyalyashpal commented Jan 24, 2023

Stypox commented Jan 28, 2023

goyalyashpal commented Jan 29, 2023

Add long press action on hashtags and web links in descriptions #7725

Add long press action on hashtags and web links in descriptions #7725

Conversation

AudricV commented Jan 30, 2022 • edited Loading

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

Due diligence

litetex left a comment • edited Loading

Choose a reason for hiding this comment

AudricV commented Jan 30, 2022

SameenAhnaf commented Jan 30, 2022 • edited by AudricV Loading

This comment has been minimized.

AudricV commented Jan 30, 2022

opusforlife2 commented Jan 30, 2022

AudricV commented Jan 30, 2022 • edited Loading

sonarqubecloud bot commented Jan 30, 2022

ktprograms commented Jan 31, 2022

Stypox left a comment

Choose a reason for hiding this comment

AudricV commented Jul 19, 2022

AudricV commented Sep 7, 2022

AudricV commented Sep 7, 2022 • edited by opusforlife2 Loading

sonarqubecloud bot commented Nov 29, 2022

Stypox left a comment • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 15, 2023

Stypox left a comment

Choose a reason for hiding this comment

goyalyashpal commented Jan 22, 2023 • edited Loading

goyalyashpal commented Jan 22, 2023

Stypox commented Jan 23, 2023

goyalyashpal commented Jan 24, 2023

Stypox commented Jan 28, 2023

goyalyashpal commented Jan 29, 2023

AudricV commented Jan 30, 2022 •

edited

Loading

litetex left a comment •

edited

Loading

SameenAhnaf commented Jan 30, 2022 •

edited by AudricV

Loading

AudricV commented Jan 30, 2022 •

edited

Loading

AudricV commented Sep 7, 2022 •

edited by opusforlife2

Loading

Stypox left a comment •

edited

Loading

goyalyashpal commented Jan 22, 2023 •

edited

Loading