Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set workaround for playback position reset when switching to main player with content thumbnail #7852

Merged

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented Feb 10, 2022

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

The workaround set with #7668 was not applied when switching to main player with content thumbnail from popup or background player. This PR fixes this by applying the workaround when switching to main player with content thumbnail from popup or background player.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Feb 10, 2022
@tsiflimagas
Copy link
Contributor

I tried it, but it doesn't work. I don't remember what was the case when I made that comment, but I found out that the right case is case R.id.detail_thumbnail_root_layout:. Sorry for the confusion, I'm not sure why I wrote that back then.

…yer with content thumbnail

The workaround set before was not applied when switching to main player with content thumbnail from popup or background player. This commit fixes this by applying the workaround when switching to main player with content thumbnail from popup or background player.
@AudricV AudricV force-pushed the player-recovery-workaround-play-thumbnail branch from d92c848 to 608e73e Compare February 11, 2022 18:33
@AudricV
Copy link
Member Author

AudricV commented Feb 11, 2022

Indeed, the overlay_thumbnail id refers to thumbnail of the content opened and/or played in mini player, as you can see in the following screenshot:

overlay_thumbnail_design_android_studio

Thank you for looking to this!

Are my last changes working (I used what you said) or not?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@tsiflimagas
Copy link
Contributor

Yes, it works as expected.

@TobiGr TobiGr merged commit c1fe5c8 into TeamNewPipe:dev Feb 11, 2022
@AudricV AudricV deleted the player-recovery-workaround-play-thumbnail branch February 11, 2022 20:00
@TobiGr TobiGr mentioned this pull request Feb 11, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video progress resets when switching to popup/background and viceversa
3 participants