Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change compileSdk from 30 to 31 #7900

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Feb 19, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR increases the compileSdk from 30 to 31. This will allow newer libraries to be used, see #7782 and #2335 (comment). This should have no changes on the app since the targetSdk stayed the same.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

This will allow newer libraries to be used, see TeamNewPipe#7782 and TeamNewPipe#2335. This should have no changes on the app since the targetSdk stayed the same.
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to do this as well :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr merged commit 750490c into TeamNewPipe:dev Feb 19, 2022
@Stypox Stypox mentioned this pull request Feb 23, 2022
3 tasks
@Stypox Stypox deleted the increment-compile-sdk branch August 4, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants