-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stream sorting. #8635
Use stream sorting. #8635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM; How can I test these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
app/src/main/java/org/schabi/newpipe/fragments/detail/DescriptionFragment.java
Outdated
Show resolved
Hide resolved
544d708
to
1faf4a3
Compare
…ionFragment.java Co-authored-by: Stypox <stypox@pm.me>
1faf4a3
to
e772244
Compare
Kudos, SonarCloud Quality Gate passed! |
This comment was marked as duplicate.
This comment was marked as duplicate.
Pls download link |
@Hanankhan1983 I don't get why you would want a download link for this pull request. Nothing has changed regarding users, this is just an internal change. Anyway, follow the steps in the "APK testing" section above (in the PR description) to obtain an apk. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@Hanankhan1983 you can already view video tags in the current version (and even in older ones), just scroll down the description tab. Those screenshots were sent just to show which features needed to be tested to make sure the under-the-hood changes this Pull Request made actually worked correctly. |
Ok |
@Hanankhan1983 Don't quote entire text blocks unless you're referring to something in them for context. |
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence