Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stream sorting. #8635

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use the Java 8 Stream API's sorting methods.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; How can I test these changes?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Jul 16, 2022

Code LGTM; How can I test these changes?

The tags can be viewed in any video under the description tab, like below:

Screenshot_20220716-192535_NewPipe.jpg

As for the other change, it's related to the playlist functionality.

Screenshot_20220716-193117_NewPipe.jpg

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Jul 17, 2022
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

…ionFragment.java

Co-authored-by: Stypox <stypox@pm.me>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox Stypox merged commit 1594716 into TeamNewPipe:dev Jul 20, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the Use_stream_sort branch July 20, 2022 23:42
@Hanankhan1983

This comment was marked as duplicate.

@Hanankhan1983
Copy link

Code LGTM; How can I test these changes?

Pls download link

@Stypox
Copy link
Member

Stypox commented Jul 25, 2022

@Hanankhan1983 I don't get why you would want a download link for this pull request. Nothing has changed regarding users, this is just an internal change.

Anyway, follow the steps in the "APK testing" section above (in the PR description) to obtain an apk.

@Hanankhan1983

This comment was marked as off-topic.

@Stypox
Copy link
Member

Stypox commented Jul 25, 2022

@Hanankhan1983 you can already view video tags in the current version (and even in older ones), just scroll down the description tab.

Those screenshots were sent just to show which features needed to be tested to make sure the under-the-hood changes this Pull Request made actually worked correctly.

@Hanankhan1983
Copy link

Hanankhan1983 commented Jul 25, 2022

Ok

@opusforlife2
Copy link
Collaborator

@Hanankhan1983 Don't quote entire text blocks unless you're referring to something in them for context.

@Stypox Stypox mentioned this pull request Aug 27, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants