-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TextViewCompat.setCompoundDrawableTintList(). #8655
Use TextViewCompat.setCompoundDrawableTintList(). #8655
Conversation
This has been marked as a draft as AppCompat 1.5.0 is still in beta. |
I like the change, but I think it's far too early for it. The compileSdk change seems completely unrelated (unless the library beta requires it), and it includes a core library bumped to a beta version (AppCompat). I'd wait until AppCompat 1.5.0 is stable before doing this, imo. |
Yeah, the library requires it.
That's why I marked it as a draft for now. I'll update once AppCompat 1.5.0 is stable. |
b6608bb
to
b7a32a0
Compare
Yeah, that needs to be done in a separate PR, along with making sure nothing is broken |
b7a32a0
to
2070078
Compare
2070078
to
cbca9df
Compare
cbca9df
to
9150769
Compare
CI was stuck on "Set up JDK 11" for 3+ hours. I cancelled and reran it. |
60e2bb3
to
4bc4c0c
Compare
Kudos, SonarCloud Quality Gate passed! |
Ok, now 1.5.1 is stable. Could you update to it, please? Then it'd be cool if @TacoTheDank could take a look, before merging. |
4bc4c0c
to
51bdc30
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
What is it?
Description of the changes in your PR
TextViewCompat.setCompoundDrawableTintList()
.Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence