Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TextViewCompat.setCompoundDrawableTintList(). #8655

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 19, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use TextViewCompat.setCompoundDrawableTintList().

Fixes the following issue(s)

  • Fixes #

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Isira-Seneviratne
Copy link
Member Author

This has been marked as a draft as AppCompat 1.5.0 is still in beta.

@TacoTheDank
Copy link
Member

I like the change, but I think it's far too early for it. The compileSdk change seems completely unrelated (unless the library beta requires it), and it includes a core library bumped to a beta version (AppCompat). I'd wait until AppCompat 1.5.0 is stable before doing this, imo.

@Isira-Seneviratne
Copy link
Member Author

I like the change, but I think it's far too early for it. The compileSdk change seems completely unrelated (unless the library beta requires it),

Yeah, the library requires it.

and it includes a core library bumped to a beta version (AppCompat). I'd wait until AppCompat 1.5.0 is stable before doing this, imo.

That's why I marked it as a draft for now. I'll update once AppCompat 1.5.0 is stable.

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Jul 26, 2022
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_TextViewCompat_setCompoundDrawableTIntList branch from b6608bb to b7a32a0 Compare August 4, 2022 01:25
@Stypox
Copy link
Member

Stypox commented Aug 4, 2022

The compileSdk change seems completely unrelated

Yeah, that needs to be done in a separate PR, along with making sure nothing is broken

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_TextViewCompat_setCompoundDrawableTIntList branch from b7a32a0 to 2070078 Compare August 5, 2022 02:09
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_TextViewCompat_setCompoundDrawableTIntList branch from 2070078 to cbca9df Compare August 13, 2022 03:59
@Isira-Seneviratne Isira-Seneviratne marked this pull request as ready for review August 13, 2022 03:59
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_TextViewCompat_setCompoundDrawableTIntList branch from cbca9df to 9150769 Compare August 13, 2022 04:01
@opusforlife2
Copy link
Collaborator

CI was stuck on "Set up JDK 11" for 3+ hours. I cancelled and reran it.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_TextViewCompat_setCompoundDrawableTIntList branch 2 times, most recently from 60e2bb3 to 4bc4c0c Compare August 15, 2022 01:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox
Copy link
Member

Stypox commented Oct 30, 2022

Ok, now 1.5.1 is stable. Could you update to it, please? Then it'd be cool if @TacoTheDank could take a look, before merging.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_TextViewCompat_setCompoundDrawableTIntList branch from 4bc4c0c to 51bdc30 Compare November 1, 2022 01:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@TacoTheDank TacoTheDank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Isira-Seneviratne Isira-Seneviratne merged commit 8488739 into TeamNewPipe:dev Nov 3, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the Use_TextViewCompat_setCompoundDrawableTIntList branch November 3, 2022 14:44
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants