Remove some unused methods. #8740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Stypox
reviewed
Aug 6, 2022
| @@ -14,13 +13,10 @@ | |||
| @Dao | |||
| public interface BasicDAO<Entity> { | |||
| /* Inserts */ | |||
| @Insert(onConflict = OnConflictStrategy.ABORT) | |||
There was a problem hiding this comment.
Why this change? Could you document such changes when you open a PR?
There was a problem hiding this comment.
Sorry, my bad. Updated the changelog.
Stypox
requested changes
Aug 6, 2022
Stypox
approved these changes
Aug 6, 2022
There was a problem hiding this comment.
Remove OnConflictStrategy.ABORT for the Room Insert annotation, as it is now the default value.
Oh ok, according to the source code blame, OnConflictStrategy.ABORT has been the default at least since 2018.
triallax
added
the
codequality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
HistoryRecordManagerand other locations.OnConflictStrategy.ABORTfor the RoomInsertannotation, as it is now the default value.Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence