Added Icelandic, Latvian, Malayalam to language selector #9179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
the
localisation / translation
TobiGr
suggested changes
Oct 24, 2022
There was a problem hiding this comment.
Thank you for working on this.
Please do not upload translation files via GitHub. The changes need to be pulled from the weblate repository. I suggest to sync all translations in this step to prevent conflicts.
To add the weblate repo to your local git repo, run
git remote add weblate https://hosted.weblate.org/git/newpipe/strings/reset your feature branch to weblate's dev and apply the changes to settings-key.xml. Commit and force push the changes to this branch.
|
Thanks to your guidance. I completed the task and deleted the files I had previously added manually. I have tested the language selector in alphabetical order and everything works fine. Please feel free to let me know if there are any more problems? |
Currently translated at 100.0% (645 of 645 strings) Translated using Weblate (French) Currently translated at 100.0% (645 of 645 strings) Translated using Weblate (Greek) Currently translated at 100.0% (645 of 645 strings) Translated using Weblate (Greek) Currently translated at 100.0% (645 of 645 strings) Translated using Weblate (French) Currently translated at 99.5% (642 of 645 strings) Translated using Weblate (Greek) Currently translated at 99.6% (643 of 645 strings) Translated using Weblate (Icelandic) Currently translated at 99.0% (636 of 642 strings) Translated using Weblate (Polish) Currently translated at 59.1% (42 of 71 strings) Translated using Weblate (Lithuanian) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Japanese) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Icelandic) Currently translated at 83.1% (534 of 642 strings) Translated using Weblate (Punjabi (Pakistan)) Currently translated at 18.3% (118 of 642 strings) Translated using Weblate (Punjabi (Pakistan)) Currently translated at 1.4% (1 of 71 strings) Translated using Weblate (Icelandic) Currently translated at 83.0% (533 of 642 strings) Translated using Weblate (Aymara (Southern)) Currently translated at 0.1% (1 of 642 strings) Translated using Weblate (Swedish) Currently translated at 60.5% (43 of 71 strings) Translated using Weblate (Russian) Currently translated at 30.9% (22 of 71 strings) Translated using Weblate (Lithuanian) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (French) Currently translated at 100.0% (642 of 642 strings) Added translation using Weblate (Punjabi (Pakistan)) Translated using Weblate (Icelandic) Currently translated at 70.0% (450 of 642 strings) Translated using Weblate (Undetermined) Currently translated at 21.4% (138 of 642 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Undetermined) Currently translated at 18.3% (118 of 642 strings) Translated using Weblate (Icelandic) Currently translated at 2.8% (2 of 71 strings) Translated using Weblate (Icelandic) Currently translated at 51.5% (331 of 642 strings) Translated using Weblate (French) Currently translated at 91.5% (65 of 71 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (71 of 71 strings) Translated using Weblate (Italian) Currently translated at 43.6% (31 of 71 strings) Translated using Weblate (Basque) Currently translated at 45.0% (32 of 71 strings) Translated using Weblate (Punjabi) Currently translated at 84.7% (544 of 642 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Tamil) Currently translated at 54.8% (352 of 642 strings) Translated using Weblate (Tamil) Currently translated at 54.8% (352 of 642 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Czech) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Korean) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (642 of 642 strings) Added translation using Weblate (Undetermined) Translated using Weblate (Icelandic) Currently translated at 7.3% (47 of 642 strings) Translated using Weblate (Icelandic) Currently translated at 4.6% (30 of 642 strings) Added translation using Weblate (Icelandic) Co-authored-by: Alex25820 <alexs25820@gmail.com> Co-authored-by: Chitraarasu <chitraarasu@kirshi.co> Co-authored-by: Chitraarasu.k <kchitraarasu@gmail.com> Co-authored-by: Fjuro <ifjuro@proton.me> Co-authored-by: Florian <flo.site@zaclys.net> Co-authored-by: Gediminas Murauskas <muziejusinfo@gmail.com> Co-authored-by: GnuPGを使うべきだ <dieeeazpnnqbpddh@cock.email> Co-authored-by: Gontzal Manuel Pujana Onaindia <thadahdenyse@gmail.com> Co-authored-by: Hoseok Seo <ddinghoya@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Linerly <linerly@protonmail.com> Co-authored-by: Mehmet Ali <2045uuttb@relay.firefox.com> Co-authored-by: Nizami <nizamismidov4@gmail.com> Co-authored-by: OneGuitars <xiaozhuojun1125@gmail.com> Co-authored-by: Retrial <giwrgosmant@gmail.com> Co-authored-by: SC <lalocas@protonmail.com> Co-authored-by: Translator <kvb@tuta.io> Co-authored-by: Trendyne <eiko@chiru.no> Co-authored-by: Vasilis K <skyhirules@gmail.com> Co-authored-by: atilluF <atilluf@outlook.com> Co-authored-by: bgo-eiu <huyaqoob+toolforge@gmail.com> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: julboudin <boudin.julie@orange.fr> Co-authored-by: rehork <cooky@e.email> Co-authored-by: Артём Нефедов <artem10397g@gmail.com> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/eu/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/is/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/it/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa_PK/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ru/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sv/ Translation: NewPipe/Metadata
TobiGr
force-pushed
the
9094-add-translations
branch
from
4c676f7 to
47259ef
Compare
TobiGr
approved these changes
Oct 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
|
@OneGuitars Just for internal tracking: was your PR part of the ANU SE course? |
Yes, I am taking this course. |
This was referenced Nov 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
I downloaded newpipe-strings-is from NewPipe weblate. I created directory(values-is) in res. I added strings (newpipe-strings-is) to values-is. I added Icelandic, Latvian, Malayalam to language selector.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence