[YouTube] Now music mixes can be treated as normal mixes #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a playlist extractor on them would result in "Unviewable playlist" errors
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was simpler than expected. A while ago, apparently, YouTube treated music playlists as just special playlists, and so a normal
YouTubePlaylistExtractorwas used to fetch them. Now, instead, when using that method you get "This playlist type is unviewable.". The solution was just to remove the distinction between other mixes and music mixes: now they are all treated the same way usingYoutubeMixPlaylistExtractor. By taking a look at the browser's network tab I could confirm this is the right approach.The first commit just changes 4 lines of code. The second one adds a mix test along with mocks.
Fixes TeamNewPipe/NewPipe#9536
Testing APK: app-debug.zip