[SoundCloud] Detect whether there are any more search results #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
TobiGr
force-pushed
the
fix/sc/search-next-page
branch
from
25718ae to
428a1ec
Compare
Add test for this edge case.
TobiGr
force-pushed
the
fix/sc/search-next-page
branch
from
428a1ec to
05f2588
Compare
TobiGr
force-pushed
the
fix/sc/search-next-page
branch
from
05f2588 to
aa6c17d
Compare
Stypox
requested changes
Aug 6, 2023
...a/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudSearchExtractor.java
Outdated
Show resolved
Hide resolved
|
@TobiGr I pushed 2947257 and changed the |
Stypox
approved these changes
Aug 6, 2023
AudricV
reviewed
Aug 6, 2023
| @@ -72,8 +63,7 @@ public InfoItemsPage<CommentsInfoItem> getPage(final Page page) throws Extractio | |||
| getServiceId()); | |||
|
|
|||
| collectStreamsFrom(collector, json.getArray("collection")); | |||
|
|
|||
| return new InfoItemsPage<>(collector, new Page(json.getString("next_href"))); | |||
| return new InfoItemsPage<>(collector, new Page(json.getString("next_href", null))); | |||
There was a problem hiding this comment.
You do not needed to specify a null fallback, as that's already the default value.
There was a problem hiding this comment.
That's right, however this is fine, too
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the extractor always assumed that there was an infinite number of search results. That has caused some problems. When searching for something with only a few results, that could cause clients such as NewPipe to try to load more results without getting more and thus causing tons of requests, ultimately resulting in reCaptcha requests.