Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept YouTube Mix playlists #276

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Don't accept YouTube Mix playlists #276

merged 1 commit into from
Mar 25, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Mar 2, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

This will let NewPipe open the actual video from the YouTube Mix playlist you're watching, as NewPipeExtractor can't handle YouTube Mix playlists yet. This would vastly improve YouTube Music support for now, as when you watch a video there, it'll automatically go to the Mix.

Or we could wait until someone implemens properly extracting those Mix playlists.

@wb9688 wb9688 added the youtube service, https://www.youtube.com/ label Mar 2, 2020
@B0pol
Copy link
Member

B0pol commented Mar 2, 2020

There is a PR for youtube mix, #253 (but was not updated to new youtube website).
To me, handling mixes is better because the behavior part of youtube music totally relies on playlist (mix are playlist), and here you break that playlist for a single video.

Why spotify (as example) has so many users: first, unlimited listening to whatever music you want, but also and that's an important thing, you listen to playlist (or "radios" / daily mixes) continuously
And Youtube music was built like that, this idea of continuous music, with mixes that are endless.

@wb9688
Copy link
Contributor Author

wb9688 commented Mar 2, 2020

@B0pol: I know, but this was intended as a temporary fix, until e.g. @XiangRongLin properly implements support for mixes. One downside of our current playlist implementation is that it doesn't store at what stream the user was though.

@PeterHindes
Copy link

Interesting. Since Mixes are endless how do you que them all?

@wb9688
Copy link
Contributor Author

wb9688 commented Mar 7, 2020

Closed in favor of #280.

@wb9688 wb9688 closed this Mar 7, 2020
@wb9688 wb9688 reopened this Mar 25, 2020
@TobiGr TobiGr merged commit bff595c into TeamNewPipe:dev Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants