Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw ContentNotSupportedException when content is known to be unsuppo… #300

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Mar 30, 2020

…rted

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

Follows the discussion we had in #250
It will greatly improve SoundCloud usability, because instead of randomly crashing, it will show the error with an appropriated UI, not a crash report, then the average user will understand why, and he can go back to play another track.
Before, the user was confused, and it went back to main kiosk each time, so it was really annoying.
Screenshots from UI:

PR in Front-end: TeamNewPipe/NewPipe#3300

@B0pol B0pol changed the title throw ContentNotSupportedException when content is know to be unsuppo… throw ContentNotSupportedException when content is known to be unsuppo… Mar 31, 2020
Copy link
Member

@theScrabi theScrabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for this so we can check this feature without having to use the front end but our CI instead.

Copy link
Contributor

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Off-topic: @theScrabi are you going to work more on NewPipe again?)

@B0pol B0pol force-pushed the hls_opus_not_supported branch from cf24e29 to 078bd30 Compare April 1, 2020 19:50
@wb9688
Copy link
Contributor

wb9688 commented Apr 1, 2020

Oh, and please also do this for channels without Videos tab (e.g. Topic channels). You'll need to handle that in the front-end as well. Btw you forgot a \n in one translation there iirc, and I'd personally prefer 2 newlines, since I think that'd look better.

@theScrabi
Copy link
Member

(Off-topic: @theScrabi are you going to work more on NewPipe again?)

I'll try to get into it again (at leas a little). Although I feel a little alien right now as I don't exactly know what is going on right now or how the code looks right now.

@B0pol B0pol force-pushed the hls_opus_not_supported branch from 51f615c to 9a7c6b7 Compare April 7, 2020 12:34
@B0pol B0pol requested a review from wb9688 April 7, 2020 14:10
ContentNotSupportedException is thrown
@wb9688 wb9688 dismissed theScrabi’s stale review April 8, 2020 14:08

Test was added

@wb9688 wb9688 merged commit a5155fb into TeamNewPipe:dev Apr 8, 2020
@B0pol B0pol deleted the hls_opus_not_supported branch April 8, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants