-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw ContentNotSupportedException when content is known to be unsuppo… #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test for this so we can check this feature without having to use the front end but our CI instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Off-topic: @theScrabi are you going to work more on NewPipe again?)
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java
Show resolved
Hide resolved
cf24e29
to
078bd30
Compare
Oh, and please also do this for channels without Videos tab (e.g. Topic channels). You'll need to handle that in the front-end as well. Btw you forgot a |
I'll try to get into it again (at leas a little). Although I feel a little alien right now as I don't exactly know what is going on right now or how the code looks right now. |
51f615c
to
9a7c6b7
Compare
...rc/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudStreamExtractor.java
Outdated
Show resolved
Hide resolved
ContentNotSupportedException is thrown
…rted
Follows the discussion we had in #250
It will greatly improve SoundCloud usability, because instead of randomly crashing, it will show the error with an appropriated UI, not a crash report, then the average user will understand why, and he can go back to play another track.
Before, the user was confused, and it went back to main kiosk each time, so it was really annoying.
Screenshots from UI:
PR in Front-end: TeamNewPipe/NewPipe#3300