Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YouTube video duration parsing #336

Merged
merged 1 commit into from
May 30, 2020
Merged

Fix YouTube video duration parsing #336

merged 1 commit into from
May 30, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented May 30, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes TeamNewPipe/NewPipe#3681

@wb9688 wb9688 added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels May 30, 2020
@TobiGr
Copy link
Contributor

TobiGr commented May 30, 2020

This should have been detected by a test.

@TobiGr TobiGr merged commit bda83fe into TeamNewPipe:dev May 30, 2020
@wb9688
Copy link
Contributor Author

wb9688 commented May 30, 2020

@TobiGr: Yeah, I'll make tests for this later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.19.4 - [Bug] Video lengths are not correct on channel view
2 participants
@wb9688 @TobiGr