Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot #552

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Add dependabot #552

merged 1 commit into from
Jun 17, 2021

Conversation

FireMasterK
Copy link
Member

This will automatically create PRs to keep dependencies up to date.

@Stypox
Copy link
Member

Stypox commented Feb 19, 2021

Wouldn't this flood newpipe with PRs to merge?

@FireMasterK
Copy link
Member Author

In a way, yes, but you can always ignore a dependency if you don't want to upgrade it.

@XiangRongLin
Copy link
Collaborator

Did you check if the test coverage and quality is high enough to merge those PRs without additional manual work?

@FireMasterK
Copy link
Member Author

I'm not sure what exactly you mean, I would say the best way to evaluate these PRs is to check the changelog, check if it compiles, check if there's any breaking change, and then decide accordingly.

I'm not sure what tests would help in evaluating such PRs 🤔.

@XiangRongLin
Copy link
Collaborator

So that if there are any changes in the behavior of the library, we know it.

  • Like if they accidently break their library and release it, we don't also break our library too.
  • Or if we relied on some unintended behaviour, which got fixed in the library, but then breaks our functionality.

@FireMasterK
Copy link
Member Author

That's a difficult question, I usually read the changelog to determine that. The only way to surely know is to test it otherwise.

@AudricV AudricV added enhancement New feature or request meta Related to the project but not strictly to code labels Mar 5, 2021
@AudricV AudricV changed the title Add dependabot. Add dependabot Mar 5, 2021
@Stypox
Copy link
Member

Stypox commented Mar 18, 2021

I'd merge this. Upgrading one thing at a time is a good idea amd we'd have to check changelogs anyway

@B0pol B0pol merged commit 598de2d into TeamNewPipe:dev Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants