Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streamPosition for comments #625

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Add streamPosition for comments #625

merged 2 commits into from
Jun 8, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented May 12, 2021

SoundCloud is the only service which supports adding comments at a specific timestamp in the stream.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API. Not sure if this is necessary

Add CommentsInfoItem.NO_LIKE_COUNT and CommentsInfoItem.NO_STREAM_POSITION.

@TobiGr TobiGr added enhancement New feature or request soundcloud service, https://soundcloud.com/ labels May 12, 2021
@opusforlife2
Copy link
Collaborator

How will this work in the UI?

@TobiGr
Copy link
Contributor Author

TobiGr commented May 14, 2021

Not sure if it is needed for NewPipe, but we could display a "at 4:20" next to the comment's author name

@opusforlife2
Copy link
Collaborator

Oh. So you've added this generally, and not specifically for Newpipe?

That is fine. I can't think of a neat way to include this in the app. The UI is too different from how Soundcloud presents it.

@TobiGr
Copy link
Contributor Author

TobiGr commented May 14, 2021

So you've added this generally, and not specifically for Newpipe?

Correct

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good


@Override
public int getStreamPosition() {
return -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a constant for this in CommentsInfoItem, something like NO_STREAM_POSITION

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍
I also added NO_LIKE_COUNT for comment likes

@TobiGr TobiGr force-pushed the commentsStreamPosition branch from 1ad7f46 to 8497311 Compare June 6, 2021 09:32
TobiGr added 2 commits June 8, 2021 10:27
SoundCloud is the only service which supports adding comments at a specific timestamp in the stream.
@TobiGr TobiGr force-pushed the commentsStreamPosition branch from 8497311 to f7f727d Compare June 8, 2021 08:29
@TobiGr TobiGr merged commit a275750 into dev Jun 8, 2021
@TobiGr TobiGr deleted the commentsStreamPosition branch June 8, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request soundcloud service, https://soundcloud.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants