Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Video Short Description in YouTube. #731

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Extract Video Short Description in YouTube. #731

merged 3 commits into from
Oct 15, 2021

Conversation

FireMasterK
Copy link
Member

@FireMasterK FireMasterK commented Sep 22, 2021 •
edited
Loading

In Trending, and Search results.

A test wasn't added for trending, since not all videos have descriptions.

Closes #726

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@FireMasterK
Extract Video Short Description in YouTube.
94efe86 
In Trending, and Search results.
@FireMasterK FireMasterK added enhancement New feature or request youtube service, https://www.youtube.com/ labels Sep 23, 2021
Stypox
Stypox previously approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a doubt about returning null or an empty string when there is no short description, but by looking at other extractors there doesn't seem to be a consistent way to do it, so it is ok like this.
Code looks good, thank you!

AudricV
AudricV previously requested changes Sep 27, 2021
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some code style issues and this can be merged.

...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java Outdated Show resolved Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java Outdated Show resolved Hide resolved
FireMasterK and others added 2 commits October 4, 2021 01:36
@FireMasterK @AudricV
Add requested changes.
d1add05 
Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
Add final.

Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
@FireMasterK
Add default implementation for getShortDescription.
6231396
@AudricV AudricV dismissed stale reviews from Stypox and themself October 4, 2021 06:29

Outdated

litetex
litetex approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobiGr TobiGr merged commit b425394 into TeamNewPipe:dev Oct 15, 2021
@FireMasterK FireMasterK deleted the short-description branch October 15, 2021 21:41
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

@AudricV AudricV AudricV left review comments

@Stypox Stypox Stypox left review comments

Assignees
No one assigned
Labels
enhancement New feature or request youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[YouTube] Support for extracting descriptionSnippet
5 participants
@FireMasterK @Stypox @litetex @AudricV @TobiGr