[YouTube] Add a comment clarifying why the panelIdentfier can be null #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
force-pushed
the
fix/npe-stream-segments
branch
from
3aae121 to
b8a6d51
Compare
triallax
reviewed
Feb 18, 2022
| @@ -1269,6 +1269,8 @@ public Locale getLanguageInfo() { | |||
|
|
|||
| // Search for correct panel containing the data | |||
| for (int i = 0; i < panels.size(); i++) { | |||
| // panelIdentifier might be null if the panel has something to do with ads | |||
| // See https://github.com/TeamNewPipe/NewPipe/issues/7792#issuecomment-1030900188 | |||
There was a problem hiding this comment.
Maybe move this to before the if statement? I'm not really sure though, so you can choose whichever you want.
TobiGr
force-pushed
the
fix/npe-stream-segments
branch
from
b8a6d51 to
b37177e
Compare
triallax
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #797