[YouTube] Add support for attributed text description #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireMasterK
reviewed
Oct 25, 2022
...or/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelperTest.java
Outdated
Show resolved
Hide resolved
FireMasterK
approved these changes
Oct 30, 2022
AudricV
requested changes
Oct 30, 2022
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java
Outdated
Show resolved
Hide resolved
...or/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelperTest.java
Outdated
Show resolved
Hide resolved
...or/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelperTest.java
Outdated
Show resolved
Hide resolved
Also update the mock of the next InnerTube endpoint response of the YoutubeStreamExtractorDefaultTest.DescriptionTestUnboxing test class with an attributedDescription instead of a regular description
AudricV
force-pushed
the
attributed-text-desc
branch
from
74a5ef7 to
099b53c
Compare
|
I resolved the conflicts, rebased the PR, removed the test changes (please open a separate PR for that), improved a bit the documentation of the method you added and squashed all the commits, as they were redundant. Thanks for your hard work! |
AudricV
approved these changes
Nov 2, 2022
Stypox
requested changes
Nov 2, 2022
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java
Outdated
Show resolved
Hide resolved
Stypox
approved these changes
Nov 3, 2022
This was referenced Nov 4, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube is currently A/B testing a new video description format. The new format includes chips with the YouTube icon for internal links, as shown below:
Internally the new format does not use a list of text components but a string with the entire plaintext content along with a list of
commandRunswhich include the link data. I included a sample file for testing (attributed_description.json).Because NewPipeExtractor falls back to the description extracted from the player endpoint, being unable to extract the new description format does not cause any issues when using NewPipe. However this should fix the description unit tests.