[YouTube] Improve duration parsing #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirion
approved these changes
Nov 9, 2022
TobiGr
added
youtube
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(No API change tho)
I have simplified ad optimized the code to parse the duration of YouTube videos.
In the previous version, the parsing method
parseDurationStringwas a bit redundant, making some extra (useless) method calls for short videos.In particular, there were calls to "sanitize" and check the "0" strings, added within the method.
This code is not only more compact, but only makes the necessary calls to
convertDurationToInt: e.g., for short videos (<1h), this approach seems twice faster on my device(s).