Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extracting audio track information #973

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Add support for extracting audio track information #973

merged 4 commits into from
Nov 15, 2022

Conversation

FireMasterK
Copy link
Member

@FireMasterK FireMasterK commented Nov 13, 2022 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Todo:

  • Write tests/modify exiting ones

cc @AudricV

@FireMasterK FireMasterK added enhancement New feature or request youtube service, https://www.youtube.com/ labels Nov 13, 2022
@FireMasterK FireMasterK mentioned this pull request Nov 13, 2022
Closed
3 tasks
@FireMasterK FireMasterK marked this pull request as ready for review November 13, 2022 23:10
TobiGr
TobiGr reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java Show resolved Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java Show resolved Hide resolved
.../org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorDefaultTest.java Outdated Show resolved Hide resolved
TobiGr
TobiGr approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue to remind us that this needs to be implemented for the other services once this PR is merged.
I let this open for one or teo days. others should have a chance to review it. If non one does, just merge it.

@FireMasterK FireMasterK mentioned this pull request Nov 14, 2022
Open
@FireMasterK FireMasterK merged commit 9bdad55 into TeamNewPipe:dev Nov 15, 2022
@FireMasterK FireMasterK deleted the audio-track branch November 15, 2022 13:22
@AudricV AudricV mentioned this pull request Jan 31, 2023
Closed
3 tasks
@AudricV AudricV mentioned this pull request Apr 13, 2023
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudricV AudricV AudricV approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FireMasterK @TobiGr @AudricV