Use immutable Map factory methods.

[Isira-Seneviratne]

• I carefully read the contribution guidelines and agree to them.
• I have tested the API against NewPipe.

[Stypox]

I think the downloader might need to add cookies, e.g. recaptcha cookies. Would it be able to do so with List.of()? I might be wrong on this though, since NewPipe itself does not actually modify the headers.

[FireMasterK]

I might be wrong on this though, since NewPipe itself does not actually modify the headers.

You're likely right, that's how we do also it on Piped:

https://github.com/TeamPiped/Piped-Backend/blob/c2132f16dd5953cf9efbb36e4ac19778e589f855/src/main/java/me/kavin/piped/utils/DownloaderImpl.java#L44

[Stypox]

Why are you changing imports? This is an unrelated change, and also related to personal preference, so it should be avoided. Also in other files. Please undo it.

[Stypox]

Wait: since you turned a music.youtube.com into a https://music.youtube.com, a mock is now missing:

java.lang.NullPointerException: No mock response for request with url 'https://music.youtube.com/youtubei/v1/music/get_search_suggestions?alt=json&key=AIzaSyC9XL3ZjWddXya6X74dJoCTL-WEYFDNX30&prettyPrint=false' exists in path 'src/test/resources/org/schabi/newpipe/extractor/services/youtube/youtubeParsingHelper'.

[Stypox]

What did you do? I think it was perfectly ok to have https:// everywhere, you just had to update the mocks...

[Isira-Seneviratne]

What did you do?

I switched to the old behavior of having the referrer exclude the URL protocol. I wasn't sure if including it would cause issues 😅

I think it was perfectly ok to have https:// everywhere, you just had to update the mocks...

Oh, okay. In that case, shall I undo the latest change?

[Stypox]

Yes