Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using asyncio.get_event_loop #58

Closed
wants to merge 2 commits into from
Closed

fix: avoid using asyncio.get_event_loop #58

wants to merge 2 commits into from

Conversation

ricky8955555
Copy link

@ricky8955555 ricky8955555 commented Jun 12, 2023

Description

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into master unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

#41

The behaviour of creating a new event loop if one doesn't already exist was removed in Python 3.12 alpha and was allegedly deprecated before then.

The get_event_loop() method of the default event loop policy now emits a DeprecationWarning if there is no current event loop set and it decides to create one. (Contributed by Serhiy Storchaka and Guido van Rossum in gh-100160.)

(see https://docs.python.org/3.12/whatsnew/3.12.html#deprecated)

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

The behaviour of creating a new event loop if one doesn't already exist was removed in Python 3.12 alpha and was allegedly deprecated before then.
@ricky8955555 ricky8955555 changed the title fix: avoid using asyncio.get_event_loop (#41) fix: avoid using asyncio.get_event_loop Jun 12, 2023
@omg-xtao omg-xtao changed the base branch from master to development June 14, 2023 13:36
@ricky8955555 ricky8955555 closed this by deleting the head repository Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant