Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Portuguese language (european Portuguese) #196

Closed
wants to merge 9 commits into from
Closed

Added Portuguese language (european Portuguese) #196

wants to merge 9 commits into from

Conversation

ranaerys
Copy link

No description provided.

@ranaerys
Copy link
Author

Had to re-submit the pull request due to me derping up and deleting my local branch

@alexanderfast
Copy link
Collaborator

Did you intend to touch ProjectSettings/GraphicsSettings.asset? If not, maybe you should consider reverting it.

@ranaerys
Copy link
Author

I didn't. I checked the wrong file. fixing it now.

Aded airlock, empty and floor localization
@alexanderfast
Copy link
Collaborator

This is absolutely not needed, but if you want a clean history you can make it look like you never touched that file in the first place. It also ensures that revert actually put the same content there that it use to have. I'm talking about git rebase. You have 6 commits you want to group so you would do git rebase -i HEAD~6, replace all words "pick" with the word "squash" in the text editor that comes up. Then --force push your branch and commits in this pull request is replaced! :)

Again, absolutely not needed. But it's an opportunity to learn some advanced git. Oh, and its a destructive operation so backup your files.

@ranaerys
Copy link
Author

Yeah, that sounds great but I'm new to this so I'll let it be. I don't mind not having a clean history. Thanks for the tip, though!

@alexanderfast
Copy link
Collaborator

Your call. Maybe next time. :)

@ranaerys ranaerys closed this Aug 20, 2016
@ranaerys ranaerys deleted the Add-pt_PT-Localization branch August 20, 2016 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants