Live power system: fixed bugs and it is should be ready to use #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .Sum(connection => | ||
| connection.AccumulatedPower - connection.OutputRate < 0.0f ? | ||
| connection.AccumulatedPower : | ||
| connection.OutputRate) < 0) |
There was a problem hiding this comment.
Ive been staring at those four lines for a while now (144-147), something needs to happen but Im not sure what. The expression is very complicated. Could we indent 144 with one tab and 145, 146, 147 with two tabs? Or, consider breaking out the logic into methods so that you just do .Sum(MyMethod);.
|
Nice! :) |
f-montanari
pushed a commit
to f-montanari/ProjectPorcupine
that referenced
this pull request
Sep 2, 2016
…orcupine#949) * Live power system: fixed bugs and it is should be ready to use * Made code more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step would be use this system.
Add to
WorldandFurniture