Fix/issue 194/filter archived sessions by start time #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLukeW
approved these changes
Nov 17, 2023
esparr
approved these changes
Nov 17, 2023
|
I went ahead and approved this. Looks good! It would be good to see if we need any basic test coverage for this endpoint but we can add a separate ticket for adding that testing. I don't want to hold up moving the front end forward. |
GitLukeW
deleted the
fix/issue-194/filter-archived-sessions-by-start-time
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
1. Targeted Issue
Issue #194: archive_sessions_list view was filtering by end time and returning an error.
2. Overview of Solution
I updated the filter to us start time instead of end time.
3. Tools Used
Filters and less than (__lt) logic
4. Testing Strategy
I added some past a future sessions and checked that the endpoint was returning the correct sessions.
5. Future Implications
Once this is on staging we can finish the front end archive sessions page.
6. Screenshots
n/a
7. Code Reviewers
Help navigating some backend issues from @GitLukeW and @esparr