Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #109 - 습관방 시작 서버 연결 #114

Merged
merged 8 commits into from
Jan 18, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 대기방에서 습관방 시작 서버 연결
  • 대기방 하단 버튼 isHost에 따라 분기처리로 hidden
  • 토스트메세지 위치 수정

📌 참고 사항

화면 전환 추후 구현

  • 대기방에서 습관방 시작 후 습관방 상세으로 이동
  • 대기방에서 홈으로 이동

📸 스크린샷

기능 스크린샷
습관방 시작하고 싶어 ezgif com-gif-maker (38)

📮 관련 이슈

@yangsubinn yangsubinn added Feat 새로운 기능 구현 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 labels Jan 18, 2022
@yangsubinn yangsubinn self-assigned this Jan 18, 2022
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

습관방 시작해주세요! 1일 1인증 하겟슴당!

Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드리뷰만 수정해서 머지해주세여~

@@ -146,6 +146,20 @@ public class RoomAPI {
}
}

func startRoom(roomID: Int, completion: @escaping(NetworkResult<Any>) -> Void) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WithApi 추가해주세여~

Comment on lines +40 to +45
// FIXME: - getFeedListFetchWithAPI 위치 변경
DispatchQueue.main.async {
self.getFeedListFetchWithAPI(lastID: self.feedLastID) {
// self.collectionView.scrollToItem(at: IndexPath(item: 0, section: 0), at: .bottom, animated: false)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거..네에.. 다 합쳐서 수정갈겨야게써어..

@yangsubinn yangsubinn merged commit 5c1cc18 into TeamSparker:develop Jan 18, 2022
@yangsubinn yangsubinn deleted the feature/#109 branch January 27, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 습관방 시작 서버 연결
3 participants