Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #110 - 나의 목표 설정 서버 연결 #127

Merged
merged 4 commits into from
Jan 19, 2022
Merged

[Feat] #110 - 나의 목표 설정 서버 연결 #127

merged 4 commits into from
Jan 19, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 나의 목표 설정 서버 연결

📌 참고 사항

📸 스크린샷

기능 스크린샷
나의 목표 설정 ezgif com-gif-maker (43)

📮 관련 이슈

@yangsubinn yangsubinn added Feat 새로운 기능 구현 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 labels Jan 19, 2022
@yangsubinn yangsubinn self-assigned this Jan 19, 2022
L-j-h-c
L-j-h-c approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수빈선배 고생하셨어라....플로우 연결까지 가보자잇~~!

Spark-iOS/Spark-iOS/Source/ViewControllers/GoalWriting/GoalWritingVC.swift
Comment on lines +149 to +150
let attributedString = NSMutableAttributedString(string: countLabel.text ?? "")
attributedString.addAttribute(NSAttributedString.Key.foregroundColor, value: UIColor.sparkPinkred, range: ((countLabel.text ?? "") as NSString).range(of: "\(String(describing: textField.text?.count ?? 0))"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

워후... 텍필의 카운트와 라벨의 숫자가 같으면 색을 바꿔주는거군뇨...넘나신기셔스

hyun99999
hyun99999 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yangsubinn yangsubinn merged commit 789f15e into TeamSparker:develop Jan 19, 2022
@yangsubinn yangsubinn deleted the feature/#110 branch January 27, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun99999 hyun99999 hyun99999 approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

Assignees

@yangsubinn yangsubinn

Labels
Feat 새로운 기능 구현 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 나의 목표 작성 서버 연결 [Feat] 목표 설정 서버 연결
3 participants
@yangsubinn @hyun99999 @L-j-h-c