Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 13프로, 13미니, SE2 기기대응 #141

Merged
merged 11 commits into from
Jan 20, 2022
Merged

[Feat] 13프로, 13미니, SE2 기기대응 #141

merged 11 commits into from
Jan 20, 2022

Conversation

L-j-h-c
Copy link
Member

@L-j-h-c L-j-h-c commented Jan 20, 2022

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 보관함 베지어패스 수정
  • 기기대응 완료한 뷰
    • Dialogue
    • SendSpark
    • CompleteAuth
    • HabitAuth
    • JoinCheck
    • CodeJoin
    • StorageMore
    • Storage

📌 참고 사항

  • 현규선배 함수에서 객체를 리턴해서 애니메이션 지워주고 만들어주는 방법 잘 배웠습니다
    • 하지만 태그 처음써서 문제 해결한게 뿌듯해서 태그로 만든 코드로 푸쉬해요! ㅎㅎ
  • authUpload 제외하고 제가 맡은 뷰 기기대응 완료입니다.
  • 보관함 뷰 무한스크롤은 일단 막아뒀습니다.

📮 관련 이슈

@L-j-h-c
[Design] TeamSparker#130 - 보관함 리스트 셀 기기별 조절
f77ae98 
보관함 리스트 셀 기기별 조절
@L-j-h-c
[Design] TeamSparker#130 - 보관함 뷰 애니메이션 기기대응
fdf2b76 
blockingView의 위치를 center가 아닌 leading기준으로 잡음
@L-j-h-c
[Design] TeamSparker#130 - 인증완료 뷰 기기대응 완료
67c49ae 
인증완료 뷰 기기대응 완료
@L-j-h-c
[Fix] TeamSparker#130 - HabitAuth 기기대응
74f0993 
HabitAuth 기기대응 레이아웃 수정
@L-j-h-c
[Fix] TeamSparker#130- CodeJoin 기기대응 완료
d49b375 
CodeJoin 레이아웃 수정
@L-j-h-c
[Merge] TeamSparker#130 - 프로젝트 최신화
6b06cdf 
# Conflicts:
#	Spark-iOS/Spark-iOS/Source/NetworkServices/Room/RoomService.swift
#	Spark-iOS/Spark-iOS/Source/SceneDelegate.swift
@L-j-h-c
[Fix] TeamSparker#130 - 보관함 뷰 디테일 수정
cc71d6b 
보관함 뷰 디테일 수정
@L-j-h-c
[Fix] TeamSparker#130 - 보관함 뷰 베지어패스 문제 해결
16cde4f 
보관함 뷰 베지어패스 문제 해결
@L-j-h-c
[Chore] TeamSparker#130 - 보관함 뷰 코드 간소화 및 무한스크롤 방지
98bd6f1 
보관함 뷰 코드 간소화 및 무한스크롤 방지
@L-j-h-c L-j-h-c added Feat 새로운 기능 구현 🧚‍♀️Devil『쥬노』 뀨의 의지 공식후계자입니다 아몰랑 P2 / Priority Middle labels Jan 20, 2022
@L-j-h-c L-j-h-c self-assigned this Jan 20, 2022
hyun99999
hyun99999 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SE2 까지 대응 고생해써여!

Spark-iOS/Spark-iOS/Source/ViewControllers/TabBar/StorageVC.swift Outdated
@@ -196,20 +189,22 @@ extension StorageVC {
failButton.setTitleColor(.sparkDarkPinkred, for: .selected)
failButton.setTitleColor(.sparkDarkPinkred, for: .highlighted)

failLabel.text = "1"
failLabel.text = "0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빈문자열로 대체해주세요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다!

Spark-iOS/Spark-iOS/Source/ViewControllers/TabBar/StorageVC.swift
Comment on lines +197 to +199
DispatchQueue.main.asyncAfter(deadline: DispatchTime.now()+0.3) { [self] in
makeDrawAboveButton(button: doingButton)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것도 고민해보구 진행해보세용!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵 오버헤드라는 점 인지했어요~!~!

@L-j-h-c
[Merge] TeamSparker#130 - 프로젝트 최신화
4c4d4e3 
# Conflicts:
#	Spark-iOS/Spark-iOS/Resource/Constants/Header.swift
@L-j-h-c
[Fix] TeamSparker#130 - 코드리뷰 반영
378de40 
코드리뷰 반영
@L-j-h-c L-j-h-c merged commit 40e08d1 into TeamSparker:develop Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun99999 hyun99999 hyun99999 approved these changes

Assignees

@L-j-h-c L-j-h-c

Labels
🧚‍♀️Devil『쥬노』 뀨의 의지 공식후계자입니다 아몰랑 Feat 새로운 기능 구현 P2 / Priority Middle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 13프로, 13미니, SE2 기기대응
2 participants
@L-j-h-c @hyun99999