[Feat] #24 - 보관함 뷰 레이아웃 구현 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StorageCVC들 추가했습니다.
StorageListDataModel 파일 추가
CarouselLayout 클래스 생성
MyButton 클래스 추가
컬렉션뷰 생성 및 캐러셀 레이아웃 적용
버튼으로 컬렉션뷰 전환 기능 구현
UIView 그라데이션 함수 추가
StorageVC 상단 라벨 구현
버튼 및 라벨 레이아웃 구현
버튼 선택 시 전환 기능 구현
코드 오류 수정
프로젝트 최신화
yangsubinn
approved these changes
Jan 13, 2022
|
|
||
| class DoingStorageCVC: UICollectionViewCell { | ||
|
|
||
| @IBOutlet weak var gradationUIView: UIView! |
There was a problem hiding this comment.
나중에 여유가 된다면 마크 주석 추가해주세여!
// MARK: - Properties
// MARK: - @IBOutlet Properties
// MARK: - @IBAction Properties
// MARK: - View Life Cycle
// MARK: - Methods > setUI, registerXib, assignDelegate 등
// MARK: - @objc Function
// MARK: - Network > 네트워크 목적을 가진 함수들
| } | ||
| } | ||
|
|
||
| extension UIView{ |
| // TODO: 컬렉션뷰 위치 스냅킷으로 잡아주기. | ||
|
|
||
| // MARK: 버튼 레이아웃 설정 | ||
| func setButtons() { |
There was a problem hiding this comment.
setUI() 랑 setLayout()으로 분리해주면 좋을 것 같아요!
Comment on lines
+67
to
+68
| addSubviews(doingButton, doneButton, failButton, DoingCV, DoneCV, FailCV) | ||
| addSubviews(upperLabel, lowerLabel, doingLabel, doneLabel, failLabel) |
There was a problem hiding this comment.
addSubviews는 setLayout()에 레이아웃 잡는 코드와 함께 있는건 어떨까여?
Comment on lines
+192
to
+197
| DoingCV.isHidden = true | ||
| DoneCV.isHidden = false | ||
| FailCV.isHidden = true | ||
| doingButton.isSelected = false | ||
| doneButton.isSelected = true | ||
| failButton.isSelected = false |
There was a problem hiding this comment.
코드를 쪼금 줄이려면 forEach를 사용하는 것도 좋을 것 같아요!
Comment on lines
+227
to
+231
| func addSubviews(_ views: UIView...) { | ||
| for view in views { | ||
| self.view.addSubview(view) | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈
추후 구현할 사항