Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] CompressionQuality 0.5로 수정 #632

Merged
merged 2 commits into from
Aug 6, 2022
Merged

[Fix] CompressionQuality 0.5로 수정 #632

merged 2 commits into from
Aug 6, 2022

Conversation

L-j-h-c
Copy link
Member

@L-j-h-c L-j-h-c commented Aug 6, 2022

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

CompressionQuality 수정

🚨참고 사항

각각 CompressionQuality를 1.0, 0.7, 0.5, 0.3으로 둔 이미지 사이즈입니다.
image

  • 1.0에서 11초, 0.7에서 2.5초, 0.5에서 1.5초 정도 업로드 시간이 소요되었습니다.
  • 육안으로 이미지 품질의 차이가 거의 구분되지 않았습니다.

📸 스크린샷

비율 1.0 0.7 0.5
스크린샷

📟 관련 이슈

@L-j-h-c L-j-h-c added Fix 오류 해결, 코드 수정 🧚‍♀️Devil『쥬노』 뀨의 의지 공식후계자입니다 아몰랑 labels Aug 6, 2022
@L-j-h-c L-j-h-c requested review from hyun99999 and yangsubinn August 6, 2022 04:43
@L-j-h-c L-j-h-c self-assigned this Aug 6, 2022
yangsubinn
yangsubinn approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오옹 육안으로 봤을 때는 진짜 차이가 안보이긴 하네여 !
감사함니다 💐

hyun99999
hyun99999 approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제로 결과물로도 보여주니 파악하기가 쉽네요! 고민끝에 좋은 방법으로 해결한 것 같습니다! 🏋️‍♀️

@L-j-h-c L-j-h-c merged commit eab76c2 into TeamSparker:develop Aug 6, 2022
@hyun99999 hyun99999 mentioned this pull request Aug 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun99999 hyun99999 hyun99999 approved these changes

@yangsubinn yangsubinn yangsubinn approved these changes

Assignees

@L-j-h-c L-j-h-c

Labels
🧚‍♀️Devil『쥬노』 뀨의 의지 공식후계자입니다 아몰랑 Fix 오류 해결, 코드 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Multipart 통신에서 이미지에 JPEGCompression 적용하기
3 participants
@L-j-h-c @hyun99999 @yangsubinn