Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #59 - 방생성 화면 플로우 연결 #64

Merged
merged 9 commits into from
Jan 15, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 방생성 플로우 연결
  • 네비게이션 컨트롤러 정리

📌 참고 사항

멀라용

📸 스크린샷

기능 스크린샷
방을 만들어볼게 하나둘셋얍 ezgif com-gif-maker (32)

📮 관련 이슈

@yangsubinn yangsubinn added Feat 새로운 기능 구현 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 labels Jan 15, 2022
@yangsubinn yangsubinn self-assigned this Jan 15, 2022
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻‍♂️

Comment on lines 120 to 128
guard let nextVC = UIStoryboard(name: Const.Storyboard.Name.waiting, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.waiting) as? WaitingVC else { return }

let navi = UINavigationController(rootViewController: nextVC)

navi.modalTransitionStyle = .crossDissolve
navi.modalPresentationStyle = .fullScreen
nextVC.photoOnly = photoOnly

present(navi, animated: true, completion: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextVC -> rootVC 로
navi -> nextVC 로 변경해주세욥!

Comment on lines +76 to +80
closeButton.snp.makeConstraints { make in
make.top.equalTo(view.safeAreaLayoutGuide).offset(14)
make.leading.equalToSuperview().inset(20)
make.width.height.equalTo(24)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

Comment on lines 171 to 174
@objc
func touchNextButton() {
// TODO: - 화면전환
print("다음")
guard let nextVC = UIStoryboard(name: Const.Storyboard.Name.createAuth, bundle: nil).instantiateViewController(withIdentifier: Const.ViewController.Identifier.createAuth) as? CreateAuthVC else { return }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음? 잡았다. 양수빈.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 잡네 . .

@yangsubinn yangsubinn merged commit a0922f7 into TeamSparker:develop Jan 15, 2022
@yangsubinn yangsubinn deleted the feature/#59 branch January 27, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 🚨review_required🚨 긴급! 빠르게 확인해야할 사항 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 방생성 플로우 화면 전환 연결
2 participants