[Feat] #655 - HabitRoomDetail 모델 수정 및 습관방 생명 빨콩, 화면 전환 추가 #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
양사장 문열어 머지해줘이😬 쾅쾅ㅇ코아ㅏㅋ와코카아 문열어 |
Merge branch 'develop' of https://github.com/TeamSparker/Spark-iOS into feature/TeamSparker#655
어어이이.. 앞에꺼 머지햇슴니다 이제 봐주십셔 @hyun99999 @L-j-h-c |
hyun99999
approved these changes
Oct 6, 2022
hyun99999
reviewed
Oct 6, 2022
Comment on lines
280
to
282
| guideVC.dismissClousure = { | ||
| // FIXME: - 생명 감소 다이얼로그 | ||
|
|
||
| } |
There was a problem hiding this comment.
@yangsubinn 요거 dismissClosure 없어줘도 될 것 같아여 의미 없는 코드가 될 것 같네여!
There was a problem hiding this comment.
저거 혹시 그 업그레이드 팝업에 쓰일까 해서 냅뒀는데 다음번에 풀리퀘때 지워서 올려두 될까여.. ? @hyun99999
There was a problem hiding this comment.
아이고 그렇네요!🙇♂️ 제가 야무지게 고려해보겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
HabitRoomDetail 모델 수정 및 생명 화면 전환 연결
🚨참고 사항
#653 이거 먼저 머지하고 봐주세요 !
📸 스크린샷
📟 관련 이슈