[Feat] #60 - 스톱워치 뷰 구현 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'develop' of https://github.com/TeamSparker/Spark-iOS into feature/TeamSparker#60
hyun99999
reviewed
Jan 16, 2022
Comment on lines
+68
to
+69
| pauseButton.setImage(UIImage(named: "btnStop"), for: .normal) | ||
| resetButton.setImage(UIImage(named: "btnReset"), for: .normal) |
There was a problem hiding this comment.
처음과 초기화 시 멈춤, 초기화 버튼이 안보이는거 같아여 확인 부탁드립니당!
Comment on lines
+82
to
+86
| private func setButton(_ button: UIButton, title: String, backgroundColor: UIColor, isEnable: Bool) { | ||
| button.setTitle(title, for: UIControl.State()) | ||
| button.isEnabled = isEnable | ||
| button.backgroundColor = backgroundColor | ||
| } |
Comment on lines
+150
to
+154
| popupVC.modalPresentationStyle = .overFullScreen | ||
| popupVC.modalTransitionStyle = .crossDissolve | ||
| popupVC.time = timeLabel.text ?? "" | ||
|
|
||
| present(popupVC, animated: true, completion: nil) |
There was a problem hiding this comment.
원래는 이전 측정 값을 팝업에 전달해야 된다는 생각으로 프로퍼티를 생성했던 것 같은데,
지금 확인해보니 쓸모없군여.. 삭제했습니다!
Comment on lines
+65
to
+69
| @objc | ||
| func touchResetButton() { | ||
| NotificationCenter.default.post(name: .resetStopWatch, object: nil) | ||
| dismiss(animated: true, completion: nil) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📌 참고 사항
📸 스크린샷
📮 관련 이슈