-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] #676 - Fastlane release lane 수정 #677
Merged
hyun99999
merged 12 commits into
TeamSparker:release-1.0.4
from
hyun99999:release-1.0.4/#676
Nov 1, 2022
Merged
[Chore] #676 - Fastlane release lane 수정 #677
hyun99999
merged 12 commits into
TeamSparker:release-1.0.4
from
hyun99999:release-1.0.4/#676
Nov 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- slack webhook url 변경
- slack webhook url 변경
- slack webhook url 변경
- build app 수정
- IDFA 없음 - precheck 할 때 앱 구매 없음
- slack url 변경
- 1.1.0
hyun99999
added
Chore
그 이외의 잡일/ 버전 코드 수정, 패키지 구조 변경, 파일 이동, 파일이름 변경
👼타락pOwEr천사현규
크로아서버 환영요
labels
Oct 30, 2022
- xcodeproj 지정
yangsubinn
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♀️👍🍎
hyun99999
commented
Nov 5, 2022
Comment on lines
-63
to
+74
increment_version_number(version_number: options[:version]) | ||
build_app(workspace: "Spark-iOS.xcworkspace", scheme: "Spark-release") | ||
increment_version_number( | ||
version_number: options[:version], | ||
xcodeproj: "Spark-iOS.xcodeproj" | ||
) | ||
build_app( | ||
workspace: "Spark-iOS.xcworkspace", | ||
scheme: "Spark-beta", | ||
export_method: "app-store", | ||
export_options: { | ||
provisioningProfiles: { | ||
"com.TeamSparker.Spark" => "Spark AppStore", | ||
"com.TeamSparker.Spark.SparkNotificationService" => "SparkNotificationService AppStore" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yangsubin
여기 였나봐요 🥲
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
🚨참고 사항
❗️ error1
프로젝트에서 in-app 결제가 없기 때문에 precheck 단계에서 in-app 결제를 제외하여 해결하였습니다.
❗️error2 - IDFA
IDFA(광고 식별자)를 사용하지 않기 때문에 submission_information 파라미터를 사용해서 IDFA 세팅을 포함해주었습니다.
📟 관련 이슈